Skip to content

Add support for bloom_filter_agg #846

Closed

Description

@andygrove

What is the problem the feature request solves?

Some TPC-H queries use bloom_filter_agg, and Comet does not have a native implementation yet.

A workaround is to set spark.sql.optimizer.runtime.bloomFilter.enabled=false.

Describe the potential solution

No response

Additional context

No response

Activity

  1. vaibhawvipul commented on Aug 24, 2024

    @vaibhawvipul
    Contributor

    I can take this up if more details are provided :)

  2. andygrove commented on Aug 24, 2024

    @andygrove
    MemberAuthor

    I can take this up if more details are provided :)

    We need to implement an equivalent of Spark's org.apache.spark.sql.catalyst.expressions.aggregate.BloomFilterAggregate.

  3. vaibhawvipul commented on Aug 25, 2024

    @vaibhawvipul
    Contributor

    ok, taking this up.

  4. mbutrovich commented on Sep 24, 2024

    @mbutrovich
    Contributor

    Accumulating some notes for this. Here's the Spark design doc on the feature:
    https://docs.google.com/document/d/16IEuyLeQlubQkH8YuVuXWKo2-grVIoDJqQpHZrE7q04/

  5. mbutrovich commented on Sep 24, 2024

    @mbutrovich
    Contributor

    It looks like we already have the filter support thanks to #179.

  6. viirya commented on Oct 1, 2024

    @viirya
    Member

    BloomFilterAggregate is only supported by ObjectHashAggregate or SortAggregate. But in Comet, we only support HashAggregate so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions