Skip to content

build: Use stable channel in rust-toolchain - #1465

Merged
andygrove merged 3 commits into
apache:mainfrom
andygrove:toolchain
Mar 3, 2025
Merged

andygrove merged 3 commits into
apache:mainfrom
andygrove:toolchain

Conversation

@andygrove

@andygrove andygrove commented Mar 3, 2025 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #1466

Rationale for this change

There is a new version of rustup and it causing builds to fail.

What changes are included in this PR?

Use "stable" channel instead of pinning to a Rust version in the rust-toolchain file. We already pin the Rust version in Cargo.toml.

How are these changes tested?

@andygrove
andygrove marked this pull request as ready for review March 3, 2025 17:23
active_profiler: Option<ProfilerGuard<'a>>,
}

impl<'a> FlamegraphProfiler<'a> {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy changes

@codecov-commenter

codecov-commenter commented Mar 3, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.56%. Comparing base (f09f8af) to head (369761e).
Report is 56 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1465      +/-   ##
============================================
+ Coverage     56.12%   58.56%   +2.44%     
- Complexity      976     1015      +39     
============================================
  Files           119      122       +3     
  Lines         11743    12249     +506     
  Branches       2251     2304      +53     
============================================
+ Hits           6591     7174     +583     
+ Misses         4012     3919      -93     
- Partials       1140     1156      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andygrove
andygrove merged commit 569ca71 into apache:main Mar 3, 2025
@andygrove
andygrove deleted the toolchain branch March 3, 2025 20:36
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulid is broken due to new rustup release

3 participants