Repository navigation
feat: Improve performance tracing feature #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
acb6d9f
refactor and add comet and spark task memory
andygrove bac6e35
save
andygrove 81cf022
save
andygrove eb47aed
save
andygrove f422d7b
fix: Check acquired memory when CometMemoryPool grows
wForget 64d7563
add log
wForget 9121eee
more improvements
andygrove c9b9078
upmerge
andygrove 892cf1b
use micros not nanos
andygrove a224489
record memory usage in MB
andygrove e3fba1c
remove TraceGuard
andygrove 870a7cb
with_trace
andygrove 34d967b
with_trace
andygrove 784d04b
with_trace
andygrove fb1ca4f
with_trace
andygrove c3c40e8
with_trace
andygrove 0ed9856
with_trace
andygrove ddcb934
upmerge
andygrove d0d8f96
upmerge
andygrove f3ab2b6
remove async marker from spill method
andygrove 0c7f448
remove async marker from shuffle_write method
andygrove d1c77c4
update docs
andygrove File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is NNN is it a task number or thread number or query number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thread number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be beneficial for the user to mention it