Repository navigation
minor: Move shuffle logic from CometExecRule to CometShuffleExchangeExec serde implementation - #2853
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2853 +/- ##
============================================
+ Coverage 56.12% 59.17% +3.04%
- Complexity 976 1339 +363
============================================
Files 119 167 +48
Lines 11743 15308 +3565
Branches 2251 2549 +298
============================================
+ Hits 6591 9058 +2467
- Misses 4012 4952 +940
- Partials 1140 1298 +158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
marked this pull request as ready for review
December 5, 2025 20:34
andygrove
commented
Dec 5, 2025
| // try native shuffle first, then columnar shuffle, then fall back to Spark | ||
| // if neither are supported | ||
| tryNativeShuffle(s).orElse(tryColumnarShuffle(s)).getOrElse(s) | ||
| convertToComet(s, CometShuffleExchangeExec).getOrElse(s) |
Member
Author
There was a problem hiding this comment.
CometExecRule now delegates to CometShuffleExchangeExec for serde
CometExecRule to CometShuffleExchangeExec serde implementation
comphead
approved these changes
Dec 5, 2025
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @andygrove this is LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
CometExecRulecontains shuffle logic that would be better located inCometShuffleExchangeExec.What changes are included in this PR?
CometShuffleExchangeExecnow implementsCometSinkCometExecRuleuses serde framework to serializeCometShuffleExchangeExecHow are these changes tested?