Skip to content

chore: ScanExec::new no longer fetches data - #2881

Merged
mbutrovich merged 2 commits into
apache:mainfrom
andygrove:remove-scan-exec-initial-scan
Dec 12, 2025
Merged

mbutrovich merged 2 commits into
apache:mainfrom
andygrove:remove-scan-exec-initial-scan

Conversation

@andygrove

@andygrove andygrove commented Dec 11, 2025 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Part of #1204

Rationale for this change

Until fairly recently, we had to fetch the first batch of data during the ScanExec constructor so that we could determine the schema based on whether any columns were dictionary-encoded. Now that ScanExec::get_next always unpacks dictionaries, we no longer need to do this.

What changes are included in this PR?

How are these changes tested?

@codecov-commenter

codecov-commenter commented Dec 11, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.36%. Comparing base (f09f8af) to head (0ca71a4).
⚠️ Report is 756 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2881      +/-   ##
============================================
+ Coverage     56.12%   59.36%   +3.23%     
- Complexity      976     1377     +401     
============================================
  Files           119      167      +48     
  Lines         11743    15339    +3596     
  Branches       2251     2546     +295     
============================================
+ Hits           6591     9106    +2515     
- Misses         4012     4945     +933     
- Partials       1140     1288     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove
andygrove marked this pull request as ready for review December 11, 2025 21:11

@mbutrovich mbutrovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Net negative line count! Thanks @andygrove!

@mbutrovich
mbutrovich merged commit 6d8b8c5 into apache:main Dec 12, 2025
199 of 201 checks passed
@andygrove
andygrove deleted the remove-scan-exec-initial-scan branch December 12, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants