Skip to content

chore: use datafusion impl of hex function - #2915

Merged
comphead merged 4 commits into
apache:mainfrom
kazantsev-maksim:df_spark_hex
Dec 16, 2025
Merged

comphead merged 4 commits into
apache:mainfrom
kazantsev-maksim:df_spark_hex

Conversation

@kazantsev-maksim

@kazantsev-maksim kazantsev-maksim commented Dec 16, 2025 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of: #2443

Rationale for this change

An implementation of hex was added in DataFusion. https://github.com/apache/datafusion/blob/main/datafusion/spark/src/function/math/hex.rs

What changes are included in this PR?

How are these changes tested

Tested with existing unit tests

@codecov-commenter

codecov-commenter commented Dec 16, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.41%. Comparing base (f09f8af) to head (be81f3e).
⚠️ Report is 769 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2915      +/-   ##
============================================
+ Coverage     56.12%   59.41%   +3.28%     
- Complexity      976     1379     +403     
============================================
  Files           119      167      +48     
  Lines         11743    15353    +3610     
  Branches       2251     2548     +297     
============================================
+ Hits           6591     9122    +2531     
- Misses         4012     4945     +933     
- Partials       1140     1286     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kazantsev-maksim nice clean up

@comphead
comphead merged commit 619f368 into apache:main Dec 16, 2025
115 checks passed
@kazantsev-maksim
kazantsev-maksim deleted the df_spark_hex branch March 1, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants