Repository navigation
docs: Add documentation to contributor guide explaining native + JVM shuffle implementation - #3055
Merged
Merged
Conversation
andygrove
marked this pull request as ready for review
January 9, 2026 17:44
andygrove
requested review from
comphead,
mbutrovich,
parthchandra and
wForget
January 12, 2026 15:47
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3055 +/- ##
============================================
+ Coverage 56.12% 59.50% +3.38%
- Complexity 976 1382 +406
============================================
Files 119 167 +48
Lines 11743 15524 +3781
Branches 2251 2575 +324
============================================
+ Hits 6591 9238 +2647
- Misses 4012 4989 +977
- Partials 1140 1297 +157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
reviewed
Jan 12, 2026
| 2. Writer receives `Iterator[Product2[K, V]]` where V is `UnsafeRow` | ||
| 3. Rows are serialized and buffered in off-heap memory pages | ||
| 4. When memory threshold or batch size is reached, `SpillWriter.doSpilling()` is called | ||
| 5. Native code (`Native.writeSortedFileNative()`) converts rows to Arrow arrays and writes IPC format |
Contributor
There was a problem hiding this comment.
Just for clarification, what's the granularity at which the JNI calls happen? For the entire buffered batch or per-row?
Member
Author
There was a problem hiding this comment.
This is called for batches of rows that have already been sorted in the JVM. I'm not yet sure what the batch sizes are.
@native def writeSortedFileNative(
addresses: Array[Long],
rowSizes: Array[Int],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Documentation to help contributors understand shuffle.
What changes are included in this PR?
How are these changes tested?