Skip to content

chore: add script to regenerate golden files for plan stability tests - #3204

Merged
andygrove merged 3 commits into
apache:mainfrom
andygrove:dev/regenerate-golden-files-script
Jan 21, 2026
Merged

andygrove merged 3 commits into
apache:mainfrom
andygrove:dev/regenerate-golden-files-script

Conversation

@andygrove

Copy link
Copy Markdown
Member

Summary

Adds a dev script that automates regenerating golden files for plan stability testing. The script:

  • Verifies JDK 17+ is configured (required for Spark 4.0 compatibility)
  • Installs Comet for each Spark version (3.4, 3.5, 4.0)
  • Runs both CometTPCDSV1_4_PlanStabilitySuite and CometTPCDSV2_7_PlanStabilitySuite with SPARK_GENERATE_GOLDEN_FILES=1
  • Supports regenerating for all versions or a specific version via --spark-version option

Usage

# Regenerate golden files for all Spark versions
./dev/regenerate-golden-files.sh

# Regenerate only for a specific Spark version
./dev/regenerate-golden-files.sh --spark-version 3.5

This makes it easier for contributors to update golden files when their changes affect query plans.

Test Plan

  • Verified script help output works correctly
  • Verified JDK version check works correctly
  • Verified Spark version validation works correctly

Note: This PR was generated with AI assistance.

Adds a dev script that automates regenerating golden files for the
CometTPCDSV1_4_PlanStabilitySuite and CometTPCDSV2_7_PlanStabilitySuite
tests across all supported Spark versions (3.4, 3.5, 4.0).

The script verifies JDK 17+ is configured (required for Spark 4.0) and
supports regenerating for a specific Spark version or all versions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@andygrove
andygrove marked this pull request as draft January 16, 2026 15:39
andygrove and others added 2 commits January 16, 2026 08:40
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@andygrove
andygrove marked this pull request as ready for review January 16, 2026 15:51
@andygrove

Copy link
Copy Markdown
Member Author

I have tested this script on macOS and Linux

@codecov-commenter

codecov-commenter commented Jan 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.91%. Comparing base (f09f8af) to head (ee2ffec).
⚠️ Report is 851 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3204      +/-   ##
============================================
+ Coverage     56.12%   59.91%   +3.78%     
- Complexity      976     1429     +453     
============================================
  Files           119      170      +51     
  Lines         11743    15688    +3945     
  Branches       2251     2596     +345     
============================================
+ Hits           6591     9399    +2808     
- Misses         4012     4973     +961     
- Partials       1140     1316     +176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbutrovich mbutrovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove!

@andygrove
andygrove merged commit ea26629 into apache:main Jan 21, 2026
214 of 217 checks passed
@andygrove
andygrove deleted the dev/regenerate-golden-files-script branch January 21, 2026 18:48
sam-1112 pushed a commit to sam-1112/datafusion-comet that referenced this pull request Sep 23, 2026
…ned (apache#6094)

Moves `iceberg` and `iceberg-storage-opendal` from 665c64e4 (2026-09-03) to
bb1e4a48 (2026-09-21), 51 commits later. Several of those land in the write
path the native writer drives: apache/iceberg-rust#3159 removes a per-row
partition-key clone in the record batch partition splitter, apache#3204 and apache#3177
replace Vec<bool> masks with BooleanBuffer, and apache#3171 stops cloning statistics
in MinMaxColAggregator::update.

The lockfile change is confined to the three iceberg crates: the resolved
dependency graph is otherwise identical, same 615 crates with no version
changes on either side.

Also records why the dependency is a git revision at all, matching the comment
convention used for the `regex` pin: no published iceberg-rust release is on
our arrow, since 0.10.1 requires arrow/parquet ^58 while Comet is on 59.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants