Repository navigation
chore: add script to regenerate golden files for plan stability tests - #3204
Merged
andygrove merged 3 commits intoJan 21, 2026
Merged
Conversation
Adds a dev script that automates regenerating golden files for the CometTPCDSV1_4_PlanStabilitySuite and CometTPCDSV2_7_PlanStabilitySuite tests across all supported Spark versions (3.4, 3.5, 4.0). The script verifies JDK 17+ is configured (required for Spark 4.0) and supports regenerating for a specific Spark version or all versions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
marked this pull request as draft
January 16, 2026 15:39
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
marked this pull request as ready for review
January 16, 2026 15:51
Member
Author
|
I have tested this script on macOS and Linux |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
============================================
+ Coverage 56.12% 59.91% +3.78%
- Complexity 976 1429 +453
============================================
Files 119 170 +51
Lines 11743 15688 +3945
Branches 2251 2596 +345
============================================
+ Hits 6591 9399 +2808
- Misses 4012 4973 +961
- Partials 1140 1316 +176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sam-1112
pushed a commit
to sam-1112/datafusion-comet
that referenced
this pull request
Sep 23, 2026
…ned (apache#6094) Moves `iceberg` and `iceberg-storage-opendal` from 665c64e4 (2026-09-03) to bb1e4a48 (2026-09-21), 51 commits later. Several of those land in the write path the native writer drives: apache/iceberg-rust#3159 removes a per-row partition-key clone in the record batch partition splitter, apache#3204 and apache#3177 replace Vec<bool> masks with BooleanBuffer, and apache#3171 stops cloning statistics in MinMaxColAggregator::update. The lockfile change is confined to the three iceberg crates: the resolved dependency graph is otherwise identical, same 615 crates with no version changes on either side. Also records why the dependency is a git revision at all, matching the comment convention used for the `regex` pin: no published iceberg-rust release is on our arrow, since 0.10.1 requires arrow/parquet ^58 while Comet is on 59.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dev script that automates regenerating golden files for plan stability testing. The script:
CometTPCDSV1_4_PlanStabilitySuiteandCometTPCDSV2_7_PlanStabilitySuitewithSPARK_GENERATE_GOLDEN_FILES=1--spark-versionoptionUsage
This makes it easier for contributors to update golden files when their changes affect query plans.
Test Plan