Repository navigation
feat(iceberg): plan WriteDelta in the split write path and keep it on the JVM DeltaWriter - #6693
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6692.
Part of #6240.
Rationale for this change
On Spark 3.5+, Iceberg merge-on-read
DELETE,UPDATEandMERGEwrite throughWriteDelta, which the split Iceberg write path does not model. The native position-delta writer planned in #6240 needs a recognised, tested dispatch point first. This keeps behaviour unchanged for users and makes the later native work a writer swap rather than a planner change.What changes are included in this PR?
WriteDeltaon Spark 3.5+; Spark 3.4 keeps the stock plan.RowDeltaUtilsoperation constants instead of copies of the numeric ids.DeltaWriter. The native Iceberg writer stays out of the delta path (CometIcebergWriteExecis never used for them).Out of scope, for later items in #6240: a native delta operator or protobuf, a native position-delete writer or file layout contract, loading previous deletes, and a native feature flag. There are no Rust changes or dependencies.
How are these changes tested?
DELETE,UPDATEandMERGEresults match the stock Iceberg JVM path.CometIcebergWriteExec.MERGEplans match the stock path with AQE on and off.WriteDelta.