Repository navigation
feat: [DO NOT MERGE] native Iceberg reads of unshredded Variant columns - #7575
Draft
mbutrovich wants to merge 4 commits into
Draft
mbutrovich wants to merge 4 commits into
mbutrovich wants to merge 4 commits into
Conversation
mbutrovich
marked this pull request as draft
November 9, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4295.
Rationale for this change
This validates apache/iceberg-rust#3683, which adds shredded Variant reads to iceberg-rust, against Comet's Iceberg suites before it merges. apache/iceberg-rust#2880 (unshredded Variant reads), which this PR validated first, has merged.
What changes are included in this PR?
The native dep is temporarily pinned to
mbutrovich/iceberg-rustat ae6c7d965572810e6d2273023a1f8eab49c68f13. That commit is the apache/iceberg-rust#3683 head with apache/iceberg-rust#3257 (Arrow 60) reverted, because Comet is still on arrow 59.CometScanRule: allow Variant at any depth in projected Iceberg columns. Empty or unresolved projections still fall back.CometExecRule: let the native Iceberg scan output Variant, asCometScanExecalready can.struct<metadata, value>to Spark'sstruct<value, metadata>.How are these changes tested?
CometIcebergNativeSuite: the Variant tests check native reads against Spark for top-level, struct, array, and map Variants, including Variant null and SQL null, and a historical snapshot after a rename.CometIcebergNativeSuite:shredded variant columns read nativelywrites shredded object, array, and timestamp Variants with Iceberg's writer, checks that the data file hastyped_valuefor each column, and checks native reads against Spark. Iceberg 1.11 shreds only top-level Variants, so the nested shredded cases are covered by the iceberg-rust tests. On the feat(arrow): read unshredded variant columns iceberg-rust#2880 pin this test fails withFeatureUnsupported.TestSparkVariantReadandTestVariantShredding. Locally, all 29TestVariantShreddingtests pass. On the feat(arrow): read unshredded variant columns iceberg-rust#2880 pin, 7 of them fail withFeatureUnsupported.CometIcebergNativeSuitetests on files without field ids fail because of fix(arrow): read nested struct fields as null for files without ids or name mapping iceberg-rust#3437, not because of Variant support:nested schema pruning on data files without field idsandmigration - INT96 timestamp. They fail the same way on the feat(arrow): read unshredded variant columns iceberg-rust#2880 pin.