Repository navigation
refactor: derive IcebergDataSource column names from its schema - #112
Merged
Merged
Conversation
…p projection - Rename the fallible IcebergDataSourceBuilder::build to try_build. - Remove IcebergDataSource's projection field and accessor. They always held the field names of its schema, which the source now derives when it needs them.
mbutrovich
requested changes
Nov 17, 2026
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
Thanks @NoahKusaba! Deriving the column names from schema removes state that could drift, and the change to the scan and the tests looks right to me.
A builder whose only terminal method can fail calls it build() and returns Result, as DataFusion's and iceberg's builders do.
gabotechs
approved these changes
Nov 18, 2026
gabotechs
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks @NoahKusaba!
gabotechs
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
IcebergDataSourcefollowing the review feedback in feat: plan Iceberg file tasks before execution #67.Rationale for this change
IcebergDataSourcestores its column names in aprojectionfield, but they are always the field names of itsschema. Two copies of the same state can drift apart.What changes are included in this PR?
projectionfield and theprojection()accessor; the column names come fromschema().Are there any user-facing changes?
Yes: use
schema()instead ofprojection().Are these changes tested?
Yes, by the existing scan tests, updated to check the schema instead of
projection().