You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Allow parsing any permutation of create sequence options #1102
I would like to be able to parse the create sequence options in any particular order instead of just what postgreslq/duckdb support. Afaik oracle for example allows any permutation of the options.
If this is something that you'd be willing accept, I would be happy to implement the necessary changes to allow any permutation and hide it behind something like a dialect flag.
Reacted by Andrew Lamb
Activity
ghost changed the title [-]Allow parsing sequence options with any order[/-][+]Allow parsing any permutation of create sequence options[/+]on Jan 20, 2024
I would like to be able to parse the create sequence options in any particular order instead of just what postgreslq/duckdb support. Afaik oracle for example allows any permutation of the options.
If this is something that you'd be willing accept, I would be happy to implement the necessary changes to allow any permutation and hide it behind something like a dialect flag.
Sounds like a good feature to me -- thank you 🙏
Given the description of the issue I don't think we need to hide this behind a dialect flag FWIW, though you could do so if you prefer
My concern is that it would create false positives, and potentially allow bad code compilation, eg parsing bad postgresql code and then compiling that back in the wrong order.
That is a reasonable concern, though I think there are examples in the crate where that already happens
Activity
[-]Allow parsing sequence options with any order[/-][+]Allow parsing any permutation of create sequence options[/+]alamb commentedon Jan 23, 2024
Sounds like a good feature to me -- thank you 🙏
Given the description of the issue I don't think we need to hide this behind a dialect flag FWIW, though you could do so if you prefer
alamb commentedon Jan 24, 2024
That is a reasonable concern, though I think there are examples in the crate where that already happens
I don't have a strong preference