You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move sqlparser-rs back into the Apache Arrow DataFusion project? #1139
The sqlparser-rs project [1] seems to have become the de-facto SQL parser
for Rust, with almost 4 million downloads so far. This was originally part
of DataFusion very early on, and I moved it into a separate project because
it seemed useful for other projects. This was before DataFusion was known
as a composable query engine, and with hindsight, I probably should have
left it as part of the DataFusion project.
Now that DataFusion has a reputation as a composable query engine, I think
it would make sense to move this code back into DataFusion, where it would
benefit from a larger community of maintainers.
I would like to hear thoughts from the Apache Arrow / DataFusion community.
Does this seem like a good idea?
Thanks,
Andy.
[1] https://github.com/sqlparser-rs/sqlparser-rs
Is the proposal to bring the code into a data fusion crate? Or just the data fusion repo?
My suggestion was simply to move the sqlparser crate into the datafusion repo. It would still be the sqlparser crate. I would image that this would just become a new top-level sqlparser directory in the repo.
Activity
alamb commentedon Feb 26, 2024
Here is a related discussion in sqlparser: #818
max-sixty commentedon Feb 26, 2024
Hi @andygrove !
Is the proposal to bring the code into a data fusion crate? Or just the data fusion repo?
andygrove commentedon Feb 26, 2024
My suggestion was simply to move the
sqlparsercrate into the datafusion repo. It would still be thesqlparsercrate. I would image that this would just become a new top-levelsqlparserdirectory in the repo.max-sixty commentedon Feb 27, 2024
Ah cool! No view in that case. (From a very happy & grateful user, thanks for the library!)
alamb commentedon Nov 13, 2024
We have completed this project -- see #1294