Skip to content

feat: Support IGNORE NULLS only for allowed aggregation functions #1206

Closed as not planned

Description

@comphead

Currently parser allows to parse queries which IMHO should be failing by unsupported syntax.
Like
SELECT COUNT(*) IGNORE NULLS FROM (values (1), (null), (2));

The allowed list for IGNORE NULLS can be found https://github.com/ronsavage/SQL/blob/master/sql-2016.ebnf

Activity

  1. alamb commented on Apr 10, 2024

    @alamb
    Contributor

    In general I think this crate focuses on parsing the syntax and leaves it to downstream crates (like datafusion) to enforce whatever semantics they want

    This is written up a bit here: https://github.com/sqlparser-rs/sqlparser-rs?tab=readme-ov-file#syntax-vs-semantics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions