You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normally, in a SQL processing system, parsing SQL is not a major bottleneck compared to actually processing data. That being said, given how many SQL strings are parsed by this crate, I think there is significant benefit to improving the performance of the SQL parser in this crate.
That being said, I also think it is important to minimize the impact on downstream crates as much as possible.
Thankfully, I think there is significant room for improvement. As as part of the adding location information, I spent some time profiling and I think there are some obvious ways to improve the performance without impacting downstream crates.
Here is the flamegraph for anyone who is interested (you can download it locally to get zoom / etc):
Locally, cargo flamegraph --bench sqlparser_bench does not appear to be doing the trick as the flamegraph appears to be at most measuring a single iteration of the benchmark.
Locally, cargo flamegraph --bench sqlparser_bench does not appear to be doing the trick as the flamegraph appears to be at most measuring a single iteration of the benchmark.
This is basically what I normally do. Sometimes it is tricky to interpret the cargo bench flamegraph as it has both the warmup and the run
So no idea why that --bench is apparently getting dropped but I've managed to get things going at least.
🎉 glad to hear you figured out a way past the current issue. I have also found argument handling with cargo bench a little strange so I don't have a great explanation 🤷
Activity
davisp commentedon Dec 7, 2024
@alamb How are you generating your flamegraphs?
Locally,
cargo flamegraph --bench sqlparser_benchdoes not appear to be doing the trick as the flamegraph appears to be at most measuring a single iteration of the benchmark.alamb commentedon Dec 9, 2024
This is basically what I normally do. Sometimes it is tricky to interpret the cargo bench flamegraph as it has both the warmup and the run
Can you post the flamegraph you have?
davisp commentedon Dec 10, 2024
So this is kinda weird. It appears the
--benchargument that should be passed to the benchmark isn't.Running
cargo flamegraph --root --bench sqlparser_bench:However, it works fine if I run flamegraph against the binary directly:
flamegraph --root -- target/release/deps/sqlparser_bench-9f7a6e6e193d8f5c --benchAnd the easier to remember version works as well:
cargo flamegraph --root --bench sqlparser_bench -- --bench:So no idea why that
--benchis apparently getting dropped but I've managed to get things going at least.alamb commentedon Dec 10, 2024
🎉 glad to hear you figured out a way past the current issue. I have also found argument handling with
cargo bencha little strange so I don't have a great explanation 🤷lovasoa commentedon May 13, 2025
@alamb : related: #1848 (we are currently serializing literal strings character by character)