Repository navigation
Conversation
alamb
left a comment
There was a problem hiding this comment.
This seems like a useful improvement to me (though as @cmoog points out a fairly large backwards incompatible change which will cause pain for downstream crates)
Any other thoughts?
cc @Dandandan and @andygrove
Thank you for this PR. I think it make sense if we do this, consistently do it for all statement variants. I would be OK to not do the same thing for |
|
Closing old seemingly stalled PR. Please re-open if this was a mistake |
|
@alamb @Dandandan I currently would love to have that approach, since my usage is requiring a lot of "unreachable!()" because of that. Is that idea still OK? I can work on that this week |
|
Hi @AugustoFKL -- I think given that the sqlparser API is basically stable, I don't really want to contemplate such a large change at this time :( |
Addresses #311
Maybe it's appropriate to continue this refactor for
Expras well as the remainingStatementvariants? Those seem much less pressing though since nearly all have <= 3 fields.