You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a part of performing this change, @jayzhan211 recommended to use min and max as a default name for the new UDFs rather than the lowercase. However, performing this change makes test fails because in several places we use MAX and MIN, for example:
I have not verified if MAX and MIN are the only UDF for which we use uppercase rather than lowercase. I personally prefer to have all SQL KEYWORDS (including UDF names) uppercase for readability
Sadly this is the last name to be lowercase, others are already converted. I don't have strong preference on upper case or lower case as long as they are all consistent
Activity
jayzhan211 commentedon Aug 2, 2024
Sadly this is the last name to be lowercase, others are already converted. I don't have strong preference on upper case or lower case as long as they are all consistent
edmondop commentedon Aug 2, 2024
Agreed,I think it's better to read
SELECT MAX(stuff) rather than SELECT max(stuff) and keep the lowercase for columns and non-keyword
[-]Align UDF name to lowercase or uppercase[/-][+]Align UDF names to lowercase or uppercase[/+]jayzhan211 commentedon Aug 2, 2024
The lowercase/uppercase conversion is quite painful since you need to change many places. Especially for dataframe test
It is worth to find out an easy way to update the dataframe test beforehand #10373