Skip to content

Remove AggregateExpr abstraction layer #11810

Closed

Description

@lewiszlw

Is your feature request related to a problem or challenge?

Now all aggr functions have been migrated to UDAF. The AggregateExpr trait just has one implementation.

impl AggregateExpr for AggregateFunctionExpr {
    ...
}

Should we remove unnecessary AggregateExpr abstraction layer?

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. jayzhan211 commented on Aug 6, 2024

    @jayzhan211
    Contributor

    It is not clear to me whether it is a good idea. Maybe hold on and review it after the refactor #11359 ?

  2. lewiszlw commented on Aug 6, 2024

    @lewiszlw
    MemberAuthor

    Sure. We could wait to see more opinions.

  3. alamb commented on Aug 19, 2024

    @alamb
    Contributor

    Now all aggr functions have been migrated to UDAF. The AggregateExpr trait just has one implementation.

    This seems like a compelling reason to remove AggregateExpr (it is unecessary and makes the code more complicated)

    It is not clear to me whether it is a good idea. Maybe hold on and review it after the refactor #11359 ?

    Now that #11359 is done, @jayzhan211 do you have any additional thoughts?

    I agree with your comment on https://github.com/apache/datafusion/pull/11989/files#r1720745280 that there is room for improvement here

  4. jayzhan211 commented on Aug 20, 2024

    @jayzhan211
    Contributor

    I think we could try removing trait AggregateExpr and see whether this simplified the code.

  5. lewiszlw commented on Aug 21, 2024

    @lewiszlw
    MemberAuthor

    trait AggregateExpr and AggregateFunctionExpr live in different crates. We should solve dependency problem first...

  6. jayzhan211 commented on Aug 21, 2024

    @jayzhan211
    Contributor

    I think the code that has AggregateExpr are all in physical layer, replacing AggregateExpr with AggregateFunctionExpr doesn't have dependency issue, did I miss anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions