You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the code that has AggregateExpr are all in physical layer, replacing AggregateExpr with AggregateFunctionExpr doesn't have dependency issue, did I miss anything?
Activity
jayzhan211 commentedon Aug 6, 2024
It is not clear to me whether it is a good idea. Maybe hold on and review it after the refactor #11359 ?
lewiszlw commentedon Aug 6, 2024
Sure. We could wait to see more opinions.
alamb commentedon Aug 19, 2024
This seems like a compelling reason to remove
AggregateExpr(it is unecessary and makes the code more complicated)Now that #11359 is done, @jayzhan211 do you have any additional thoughts?
I agree with your comment on https://github.com/apache/datafusion/pull/11989/files#r1720745280 that there is room for improvement here
jayzhan211 commentedon Aug 20, 2024
I think we could try removing
trait AggregateExprand see whether this simplified the code.lewiszlw commentedon Aug 21, 2024
trait AggregateExprandAggregateFunctionExprlive in different crates. We should solve dependency problem first...jayzhan211 commentedon Aug 21, 2024
I think the code that has
AggregateExprare all in physical layer, replacingAggregateExprwithAggregateFunctionExprdoesn't have dependency issue, did I miss anything?