Skip to content

Move JoinSelection into datafusion-physical-optimizer crate #14073

Closed

Description

@alamb

Is your feature request related to a problem or challenge?

Historically DataFusion was one (very) large crate datafusion, and as it grew bigger we extracted various functionality into separate crates. This leads to both faster compile times (as the crates can be compiled in parallel) as well easier to navigate code (as the crates force a cleaner dependency separation)

One project we have not yet completed is to extract the physical optimizer passes out #11502

Describe the solution you'd like

Extract the JoinSelection from the datafusion core crate to the datafusion-physical-optimizer crate

Describe alternatives you've considered

Move https://github.com/apache/datafusion/blob/main/datafusion/core/src/physical_optimizer/join_selection.rs to
https://github.com/apache/datafusion/tree/main/datafusion/physical-optimizer/src/

Additional context

Here is an example PR:

I think this is a good first issue as it is mostly mechanical and does not require deep internals knowledge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions