Skip to content

Update workspace / CI to Rust 1.87 #16061

Closed

Description

@alamb

Is your feature request related to a problem or challenge?

Rust 1.87 was released today: https://releases.rs/docs/1.87.0/

Describe the solution you'd like

I would like to update the CI tests and checkouts to Rust 1.87

Describe alternatives you've considered

Here is an example of the update to 1.86 from @jsai28 ❤

Basically update the rust-toolchain.toml file and then run clippy to get a clean run

Additional context

No response

Activity

  1. alamb commented on May 15, 2025

    @alamb
    ContributorAuthor

    I think this is pretty straightforward and has a good example to follow

  2. kadai0308 commented on May 16, 2025

    @kadai0308
    Contributor

    Hi @alamb, I'm new here and excited to contribute to the project. Could you please assign the ticket to me? Looking forward to getting started!

  3. DanielFrantes commented on May 16, 2025

    @DanielFrantes

    @kadai0308 hi just wrote a comment with only the word "take" here

  4. kadai0308 commented on May 16, 2025

    @kadai0308
    Contributor

    take

  5. alamb commented on May 16, 2025

    @alamb
    ContributorAuthor
  6. kadai0308 commented on May 16, 2025

    @kadai0308
    Contributor

    @alamb
    After updating to Rust 1.87, I encountered several warnings such as:

    warning: large size difference between variants
       --> datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:523:1
        |
    523 | / enum ConstSimplifyResult {
    524 | |     // Expr was simplified and contains the new expression
    525 | |     Simplified(ScalarValue),
        | |     ----------------------- the second-largest variant contains at least 64 bytes
    ...   |
    529 | |     SimplifyRuntimeError(DataFusionError, Expr),
        | |     ------------------------------------------- the largest variant contains at least 384 bytes
    530 | | }
        | |_^ the entire enum is at least 384 bytes
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
        = note: `#[warn(clippy::large_enum_variant)]` on by default
    help: consider boxing the large fields to reduce the total size of the enum
        |
    529 -     SimplifyRuntimeError(DataFusionError, Expr),
    529 +     SimplifyRuntimeError(DataFusionError, Box<Expr>),
    

    To resolve these warnings, I applied several changes involving the use of Box for large enum variants. This required updating the types across multiple locations in the codebase.

    I'm not entirely confident that all the necessary typing changes were done correctly, so I'd appreciate a thorough review of this PR.

    Thanks!

  7. alamb commented on May 16, 2025

    @alamb
    ContributorAuthor

    Thanks @kadai0308 -- I left some comments on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions