You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@alamb
After updating to Rust 1.87, I encountered several warnings such as:
warning: large size difference between variants
--> datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:523:1
|
523 | / enum ConstSimplifyResult {
524 | | // Expr was simplified and contains the new expression
525 | | Simplified(ScalarValue),
| | ----------------------- the second-largest variant contains at least 64 bytes
... |
529 | | SimplifyRuntimeError(DataFusionError, Expr),
| | ------------------------------------------- the largest variant contains at least 384 bytes
530 | | }
| |_^ the entire enum is at least 384 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
529 - SimplifyRuntimeError(DataFusionError, Expr),
529 + SimplifyRuntimeError(DataFusionError, Box<Expr>),
To resolve these warnings, I applied several changes involving the use of Box for large enum variants. This required updating the types across multiple locations in the codebase.
I'm not entirely confident that all the necessary typing changes were done correctly, so I'd appreciate a thorough review of this PR.
Activity
alamb commentedon May 15, 2025
I think this is pretty straightforward and has a good example to follow
kadai0308 commentedon May 16, 2025
Hi @alamb, I'm new here and excited to contribute to the project. Could you please assign the ticket to me? Looking forward to getting started!
DanielFrantes commentedon May 16, 2025
@kadai0308 hi just wrote a comment with only the word "take" here
kadai0308 commentedon May 16, 2025
take
alamb commentedon May 16, 2025
Thanks @kadai0308 and @DanielFrantes
kadai0308 commentedon May 16, 2025
@alamb
After updating to Rust 1.87, I encountered several warnings such as:
To resolve these warnings, I applied several changes involving the use of Box for large enum variants. This required updating the types across multiple locations in the codebase.
I'm not entirely confident that all the necessary typing changes were done correctly, so I'd appreciate a thorough review of this PR.
Thanks!
alamb commentedon May 16, 2025
Thanks @kadai0308 -- I left some comments on the PR