You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review uses of "{b:02x}" to hex-encode bytes #19569
Is your feature request related to a problem or challenge?
There are numerous places in the code where write! is used in conjunction with format string "{b:02x}". There are faster ways to write hex-encoded bytes. See #19568 for an example.
I've opened a #20719 for the last usage of write! but I'm not sure if it is needed since it does not seem to be in a hot path. Another approach can be closing the PR and issue since there are no more usages. WDYT @andygrove?
Activity
shashidhar-bm commentedon Dec 31, 2025
take
perf: Improve performance of `md5` (#19568)
perf: Improve performance of hex encoding in spark functions (#19586)
buraksenn commentedon Mar 5, 2026
I've opened a #20719 for the last usage of write! but I'm not sure if it is needed since it does not seem to be in a hot path. Another approach can be closing the PR and issue since there are no more usages. WDYT @andygrove?
Used constant with mapping instead of write! to display scalar value …
Used constant with mapping instead of write! to display scalar value …