Skip to content

Review uses of "{b:02x}" to hex-encode bytes #19569

Description

@andygrove

Is your feature request related to a problem or challenge?

There are numerous places in the code where write! is used in conjunction with format string "{b:02x}". There are faster ways to write hex-encoded bytes. See #19568 for an example.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. shashidhar-bm commented on Dec 31, 2025

    @shashidhar-bm
    Contributor

    take

  2. buraksenn commented on Mar 5, 2026

    @buraksenn
    Contributor

    I've opened a #20719 for the last usage of write! but I'm not sure if it is needed since it does not seem to be in a hot path. Another approach can be closing the PR and issue since there are no more usages. WDYT @andygrove?

  3. added a commit that references this issue on Mar 10, 2026
    6f86c8d
  4. added a commit that references this issue on Mar 24, 2026
    a41b8c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions