Skip to content

Optimize spark sha2 #20046

Closed

Description

@Jefffrey

Is your feature request related to a problem or challenge?

comet reference:

Opportunities for refactoring:

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. added theissue type on Jan 28, 2026
  2. kumarUjjawal commented on Jan 31, 2026

    @kumarUjjawal
    Contributor

    Doesn't SHA2 already has a dedicated scalar implementation (digest_to_scalar!), so it doesn’t rely on make_scalar_function/values_to_arrays for scalars?

    https://github.com/apache/datafusion/blob/a02e6836e7d449008eef592b177ea282595e027a/datafusion/functions/src/crypto/sha.rs#L158C1-L161C6

  3. Jefffrey commented on Jan 31, 2026

    @Jefffrey
    ContributorAuthor

    Not for the Spark version

  4. added a commit that references this issue on Feb 5, 2026
    c92ba29
  5. added a commit that references this issue on Mar 24, 2026
    4463415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions