Skip to content

Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet #6513

Closed

Description

@alamb

TDLR is that ensuring that launched tasks are properly cleaned up (and panics are propagated back to the main tasks) is tricky.

Tokio has a tokio::task::JoinSet which handles the cleanup part and #6507 demonstrates how to use JoinSet to propagate panics.

We should ideally also fix
datafusion/core/src/physical_plan/repartition/mod.rs to propagate panics
and remove AbortOnDrop andAbortOnDropMany with JoinSet

Originally posted by @crepererum in #6449 (comment)

Subtasks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions