Skip to content

TPC-H q8 fails with overflow (since version 28) #7216

Closed

Description

@andygrove

Describe the bug

Arrow error: Compute error: Overflow happened on: 19293795273 * 100000000000000000000000000000000000000

To Reproduce

Here is a Google colab notebook that demonstrates the issue

https://colab.research.google.com/drive/13vCffhO1-IP3NtXT1FgO-j6MwoQZlPtm?usp=sharing

Expected behavior

No response

Additional context

This was originally discovered by Mimoune Djouallah:

https://twitter.com/mim_djo/status/1686955130812542976?s=20

Activity

  1. changed the title [-]TPC-H q8 fails with overflow (seems to be a new regression in 28.0.0)[/-] [+]TPC-H q8 fails with overflow\[/+] on Aug 7, 2023
  2. changed the title [-]TPC-H q8 fails with overflow\[/-] [+]TPC-H q8 fails with overflow[/+] on Aug 7, 2023
  3. changed the title [-]TPC-H q8 fails with overflow[/-] [+]TPC-H q8 fails with overflow (since version 28)[/+] on Aug 7, 2023
  4. andygrove commented on Aug 7, 2023

    @andygrove
    MemberAuthor

    I confirmed that this issue does not happen with version 27

  5. andygrove commented on Aug 7, 2023

    @andygrove
    MemberAuthor

    Ok, I see that earlier versions returned the wrong result. It is better now that we fail, but will leave this issue open because we shouldn't fail either.

    Related issue: #6794

  6. alamb commented on Aug 8, 2023

    @alamb
    Contributor

    I think this may be fixed now that #6832 has been merged

  7. viirya commented on Aug 8, 2023

    @viirya
    Member

    I've added additional cast to make TPCH q8 pass under benchmark. Let's see now if it can be passed after #6832.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions