You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consolidate and clean up tests / make them more uniform / refactor #743
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
As @jorgecarleitao pointed out many moons ago, in apache/arrow#9936 (review) , the tests in datafusion/src/context.rs are not really unit tests. They are more like SQL integration tests.
There is also a small and languishing set of sql tests in rust/datafusion/tests/sql.rs that use a string comparison style that I personally find quite hard to upgrade.
Among other things, this split makes it hard to understand the state of DataFusion's test coverage.
Since these tests are critical for DataFusion's quality, I propose a small reorganization so it is easier to find existing test coverage and write new ones:
changed the title [-]Consolidate datafusion test / make them more uniform[/-][+]Consolidate and clean up datafusion test / make them more uniform[/+]on Oct 15, 2021
changed the title [-]Consolidate and clean up datafusion test / make them more uniform[/-][+]Consolidate and clean up tests / make them more uniform[/+]on Oct 15, 2021
changed the title [-]Consolidate and clean up tests / make them more uniform[/-][+]Consolidate and clean up tests / make them more uniform / refactor[/+]on Dec 28, 2021
Activity
[-]Consolidate datafusion test / make them more uniform[/-][+]Consolidate and clean up datafusion test / make them more uniform[/+][-]Consolidate and clean up datafusion test / make them more uniform[/-][+]Consolidate and clean up tests / make them more uniform[/+]matthewmturner commentedon Nov 24, 2021
@alamb i believe we can mark task 2 completed now. If you agree then I can start looking at 3
alamb commentedon Nov 24, 2021
Done, and THANK YOU!
[-]Consolidate and clean up tests / make them more uniform[/-][+]Consolidate and clean up tests / make them more uniform / refactor[/+]chore: Add criterion benchmark for decimal_div (apache#743)
chore: Add criterion benchmark for decimal_div (apache#743)