Skip to content

explicitly list out all Expr types in TypeCoercionRewriter::mutate #8990

Closed

Description

@guojidan
          It might make sense to remove the catch all  from this `match` expression

https://github.com/apache/arrow-datafusion/blob/bc0ba6a724aaaf312b770451718cbce696de6640/datafusion/optimizer/src/analyzer/type_coercion.rs#L413

And explicitly list out all Expr types so that we don't accidentally another Expr type in the future

Is that something you might be willing to do in another PR @guojidan ?

Originally posted by @alamb in #8982 (comment)

Activity

  1. guojidan commented on Jan 25, 2024

    @guojidan
    ContributorAuthor

    wait #8982 merged

  2. alamb commented on Jan 25, 2024

    @alamb
    Contributor

    wait #8982 merged

    Sorry for the delay, #8982 is now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions