Skip to content

Refactor Spark expm1 signature - #18655

Merged
Jefffrey merged 1 commit into
apache:mainfrom
Jefffrey:refactor-expm1-signature
Nov 14, 2025
Merged

Jefffrey merged 1 commit into
apache:mainfrom
Jefffrey:refactor-expm1-signature

Conversation

@Jefffrey

@Jefffrey Jefffrey commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #12725

Rationale for this change

Prefer to avoid user_defined for consistency in function definitions.

What changes are included in this PR?

Refactor signature of expm1 away from user_defined.

Are these changes tested?

Existing tests

Are there any user-facing changes?

No

@martin-g martin-g left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbutrovich mbutrovich added the spark Changes to datafusion-spark crate label Nov 12, 2025

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jefffrey

@Jefffrey
Jefffrey added this pull request to the merge queue Nov 14, 2025
Merged via the queue into apache:main with commit 37dbf9e Nov 14, 2025
@Jefffrey
Jefffrey deleted the refactor-expm1-signature branch November 14, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spark Changes to datafusion-spark crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants