Skip to content

refactor: Spark ascii signature away from user_defined - #19513

Merged
Jefffrey merged 1 commit into
apache:mainfrom
kumarUjjawal:refactor/spark_ascii_user_defined
Dec 29, 2025
Merged

Jefffrey merged 1 commit into
apache:mainfrom
kumarUjjawal:refactor/spark_ascii_user_defined

Conversation

@kumarUjjawal

@kumarUjjawal kumarUjjawal commented Dec 27, 2025 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

As per the goal stated that we should avoid using the user_defined in useful places.

What changes are included in this PR?

  • Refactored Spark ascii to not use user_defined.
  • Checked the Spark code to make sure it follows the same convention

Are these changes tested?

  • This is a refactoring so no new tests were added but all previous test pass.

Are there any user-facing changes?

@github-actions github-actions Bot added the spark Changes to datafusion-spark crate label Dec 27, 2025
@Jefffrey
Jefffrey added this pull request to the merge queue Dec 29, 2025
Merged via the queue into apache:main with commit 83ed192 Dec 29, 2025
29 checks passed
@Jefffrey

Copy link
Copy Markdown
Contributor

Thanks @kumarUjjawal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spark Changes to datafusion-spark crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants