Repository navigation
fix: maintain inner list nullability for array_sort - #19948
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_sortfails on list with inner non-nullable field #19947Rationale for this change
#17657 introduced a regression since it cloned the inner field in the execution path but in the
return_typefunction it still set nullability to true. Fix to ensure we maintain the field of the inner field as is.What changes are included in this PR?
Change
return_typeto just pass through the input datatype as is.Also refactor away usage of a null buffer builder in favour of copying the input array null buffer.
Are these changes tested?
Added tests.
Are there any user-facing changes?
No.