Repository navigation
Pipeline non-null dictionary hash scatter on AArch64 - #26849
Rich-T-kid wants to merge 1 commit into
Conversation
|
run benchmark with_hashes |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (091664e) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (091664e) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
|
run benchmark with_hashes env:
BENCH_FILTER: dictionary_scatter
baseline:
ref: "f37a77d8a"
changed:
ref: "d8ff9f4c4" |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Runner log (last 40 lines)Kubernetes messageFile an issue against this benchmark runner |
|
run benchmark with_hashes env:
BENCH_FILTER: dictionary_scatter
baseline:
ref: "f37a77d8a70d1c692c273c20bf7f75be325ac6a9"
changed:
ref: "1194bbc7cac88dd49f8e74baa323bc042c282b82" |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing 1194bbc (1194bbc) to f37a77d diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dictionary_scatter"
baseline:
ref: "f37a77d8a70d1c692c273c20bf7f75be325ac6a9"
changed:
ref: "1194bbc7cac88dd49f8e74baa323bc042c282b82"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing 1194bbc (1194bbc) to f37a77d diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dictionary_scatter"
baseline:
ref: "f37a77d8a70d1c692c273c20bf7f75be325ac6a9"
changed:
ref: "1194bbc7cac88dd49f8e74baa323bc042c282b82"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
1194bbc to
db1b138
Compare
|
run benchmark with_hashes |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (db1b138) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (db1b138) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
91256d1 to
d5444aa
Compare
|
run benchmark with_hashes |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (d5444aa) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (d5444aa) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
d5444aa to
427927c
Compare
|
run benchmark with_hashes |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (427927c) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (427927c) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
427927c to
78d4a14
Compare
|
run benchmark with_hashes |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (78d4a14) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (78d4a14) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
|
run benchmark with_hashes |
78d4a14 to
93838ec
Compare
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (93838ec) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (93838ec) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
|
run benchmark with_hashes |
93838ec to
785b7df
Compare
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (785b7df) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (785b7df) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
00d3076 to
a142b66
Compare
|
run benchmark with_hashes |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (a142b66) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (a142b66) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
a142b66 to
fc0397a
Compare
|
run benchmark with_hashes |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/optimize-dictionary-key-scatter (fc0397a) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/optimize-dictionary-key-scatter (fc0397a) to af752e5 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "dict"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
Which issue does this PR close?
Related to #26780.
Rationale for this change
Scattering cached dictionary hashes performs an indexed load for each key. On AArch64, the scalar composite-hash loop does not expose enough independent loads to consistently hide that latency.
What changes are included in this PR?
For non-null composite dictionary hashes on AArch64, load eight dictionary hashes before combining them with the row hashes. This gives the CPU independent loads to overlap. The tail remains scalar.
Fresh hashes, nullable dictionaries, and other architectures keep the existing loop. There is no dictionary-size threshold or explicit prefetching.
Results
The upstream Neoverse-V2 run improved the existing
multiple, no nullsbenchmark from 10.8 us to 10.4 us. The single-column and nullable cases were unchanged.The upstream bot also tested 4, 16, and 32 lanes. Four lanes measured 10.7 us; 16 and 32 lanes measured 10.4 us. Eight lanes is retained as the smallest best-performing width.
What is the testing strategy for this PR?
The hash utility tests pass in normal and
force_hash_collisionsconfigurations. Workspace formatting, Clippy, and typo checks pass.Are there any user-facing changes?
No.