Repository navigation
test: trim the canceled hash join partition reproducer's EXPLAIN - #27414
Merged
Merged
Conversation
The logical plan in the EXPLAIN snapshot does not check any prerequisite of the hang, so unrelated formatting changes would churn it. The test also relied on the default of enable_dynamic_filter_pushdown. Set physical_plan_only around the EXPLAIN, and set and reset enable_dynamic_filter_pushdown explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow-up to #27345. It applies the two optional suggestions from @kosiew's review: #27345 (review)
What changes are included in this PR?
datafusion.explain.physical_plan_only = truearound theEXPLAIN, so the snapshot holds only the physical plan. The physical plan shows every prerequisite of the hang.datafusion.optimizer.enable_dynamic_filter_pushdown = trueexplicitly and resets it at cleanup. This documents the coordinator prerequisite instead of relying on the default.Are these changes tested?
Yes.
cargo test -p datafusion-sqllogictest --test sqllogictests -- join_dynamic_filter_canceled_partitionpasses.Are there any user-facing changes?
No.