Skip to content

test: trim the canceled hash join partition reproducer's EXPLAIN - #27414

Merged
adriangb merged 1 commit into
apache:mainfrom
adriangb:slt-21625-review-followup
Nov 16, 2026
Merged

adriangb merged 1 commit into
apache:mainfrom
adriangb:slt-21625-review-followup

Conversation

@adriangb

Copy link
Copy Markdown
Contributor

Rationale for this change

Follow-up to #27345. It applies the two optional suggestions from @kosiew's review: #27345 (review)

What changes are included in this PR?

  • The test sets datafusion.explain.physical_plan_only = true around the EXPLAIN, so the snapshot holds only the physical plan. The physical plan shows every prerequisite of the hang.
  • The test sets datafusion.optimizer.enable_dynamic_filter_pushdown = true explicitly and resets it at cleanup. This documents the coordinator prerequisite instead of relying on the default.

Are these changes tested?

Yes. cargo test -p datafusion-sqllogictest --test sqllogictests -- join_dynamic_filter_canceled_partition passes.

Are there any user-facing changes?

No.

The logical plan in the EXPLAIN snapshot does not check any prerequisite
of the hang, so unrelated formatting changes would churn it. The test
also relied on the default of enable_dynamic_filter_pushdown.

Set physical_plan_only around the EXPLAIN, and set and reset
enable_dynamic_filter_pushdown explicitly.
@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Nov 13, 2026
@adriangb
adriangb requested a review from kosiew November 13, 2026 23:10

@kosiew kosiew left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adriangb, thanks for addressing the review suggestions from #27354.

The changes make the dynamic-filter prerequisite explicit and limit the EXPLAIN snapshot to the physical plan, preserving the regression coverage while reducing maintenance overhead.

LGTM!

@adriangb
adriangb added this pull request to the merge queue Nov 16, 2026
Merged via the queue into apache:main with commit 9b92057 Nov 16, 2026
43 checks passed
@adriangb
adriangb deleted the slt-21625-review-followup branch November 16, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt) v57.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants