Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3354 +/- ##
==========================================
- Coverage 85.47% 85.45% -0.03%
==========================================
Files 294 294
Lines 54059 54079 +20
==========================================
+ Hits 46209 46212 +3
- Misses 7850 7867 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @ghubkoa
I think most of these paths are basically impossible to hit in reality, but the Result plumbing is good.
|
@alamb @xudong963 It looks like there are some issues with jit tests and I am looking into it. |
|
@alamb @xudong963 @andygrove I need help to fix this PR. After spending some time on this I was able to figure out that the JIT tests are failing with below message.
The error happens when calling the function The function And signature of the I need to make changes in two places
Do you guys have any inputs on how to go about this? |
|
perhaps @yjshen may have some input |
|
Currently, the use of external For the reader case we are meeting here, I personally think it's OK to panic here since we are deserializing |
I stumbled upon the rust book article which suggests to return If I don't get any opposing views, I'll revert the code for the Edit: This PR becomes redundant if the |
|
|
Which issue does this PR close?
Partial fix for #3317
Rationale for this change
Replace panic with Result.
What changes are included in this PR?
Replace panic with replace in below places
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":302 .unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":310 .unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":337 let to = to.as_any_mut().downcast_mut::().unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":350 let to = to.as_any_mut().downcast_mut::().unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":377 _ => unimplemented!(),
"/home/andy/git/apache/arrow-datafusion/datafusion/row/src/reader.rs":404 _ => unimplemented!(),
Are there any user-facing changes?
Not sure. Few functions are modified to return
Result. Not sure if they are part of public API.