Skip to content

Minor: remove tokio_stream dependency - #6565

Merged
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/remove_tokio_stream
Jun 7, 2023
Merged

alamb merged 1 commit into
apache:mainfrom
alamb:alamb/remove_tokio_stream

Conversation

@alamb

@alamb alamb commented Jun 6, 2023 •

Copy link
Copy Markdown
Contributor

Draft as it Builds on #6507

Which issue does this PR close?

N/A

Rationale for this change

We don't really use this crate, so we can reduce the dependnecy load of DataFusion

What changes are included in this PR?

Now that I know enough futures fu to do so, RecordBatchReceiverStream be easily be replaced with futures::stream::unfold

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No

@alamb
alamb force-pushed the alamb/remove_tokio_stream branch from bd21382 to 9f1f104 Compare June 6, 2023 19:39
@alamb
alamb marked this pull request as ready for review June 6, 2023 19:51

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@alamb
alamb merged commit ce76f1b into apache:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants