Skip to content

【BUG】where date in (int) will be cast to double type #4805

Closed

Description

@xinghuayu007

Describe the bug
select * from table date in (20201030), date is type of DATE or DATETIME. date and 20201030 will be casted to DOUBLE type. When date is partition key, it will cause exeption. It is better to cast 20201030 to date type.

To Reproduce
Steps to reproduce the behavior:

  1. create a table
    CREATE TABLEinvalid_date( datedatetime NULL COMMENT "", daydate NULL COMMENT "", site_id int(11) NULL COMMENT "" ) ENGINE=OLAP DUPLICATE KEY(date, day, site_id) COMMENT "OLAP" PARTITION BY RANGE(day) (PARTITION p20201030 VALUES [('2020-10-30'), ('2020-10-31'))) DISTRIBUTED BY HASH(site_id) BUCKETS 10 PROPERTIES ( "replication_num" = "1", "in_memory" = "false", "storage_format" = "V2" );
  2. execute a query:
    select date from invalid_date where day in (20201030);
  3. See error
    2020-10-27 15-39-32屏幕截图
    2020-10-27 15-39-57屏幕截图

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Activity

  1. Yao-MR-zz commented on Oct 28, 2020

    @Yao-MR-zz

    why must cast the int to date type?

    in my idea, i think this the type cast problem, so the problem is what is the type should the cast the int to,

    so just cast the int to the type of the partition key type,

    and i also doubt that why scan the all partion.

    myabe this is the right flow ,

    1, we should know that the condition key has the partion key, and get the info from the catalog

  2. xinghuayu007 commented on Oct 28, 2020

    @xinghuayu007
    ContributorAuthor

    Yes, this is the problem of type-casting. In current system, sql like select * from table where date in (20201030); date is type of DATE; date and 20201030 will be casted to DOUBLE type. That is not corret. I think the invalid type should be found in Analyze Phase, not be found in phase of 'Pruning Partitions'. This problem will not cause to scan all partitions.

  3. xinghuayu007 commented on Oct 28, 2020

    @xinghuayu007
    ContributorAuthor

    why must cast the int to date type?

    in my idea, i think this the type cast problem, so the problem is what is the type should the cast the int to,

    so just cast the int to the type of the partition key type,

    and i also doubt that why scan the all partion.

    myabe this is the right flow ,

    1, we should know that the condition key has the partion key, and get the info from the catalog

    Yes, this is the problem of type-casting. In current system, sql like select * from table where date in (20201030); date is type of DATE; date and 20201030 will be casted to DOUBLE type. That is not corret. I think the invalid type should be found in Analyze Phase, not be found in phase of 'Pruning Partitions'. This problem will not cause to scan all partitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions