Repository navigation
[fix](topn) Generate unique TopN lazy fetch schema #67958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Baymine
wants to merge
2
commits into
apache:master
Choose a base branch
from
Baymine:fix/topN-alias
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Keep a blocked alias's shared source eager
For
SELECT lazy_col AS first_alias, lazy_col AS second_alias FROM t ORDER BY first_alias LIMIT 1, the order key blocks onlyfirst_alias, so this per-expression decision pullssecond_aliasand leavesProject(lazy_col AS first_alias, lazy_col)below TopN. Withtopn_lazy_materialization_using_index=true, the exposedlazy_colis then classified lazy;LazySlotPruningremoves it from the scan/direct projection but retainslazy_col AS first_alias, and the final Validator rejects the plan because the alias reads a slot its child no longer produces. Before this change the lower identity Alias was rejected in the index path and the TopN stayed eager, so this is a regression. Please make pull-up/materialization eligibility coherent for the whole repeated-source group (or otherwise keep the shared source eager) and cover ORDER BY alias/ordinal through final translation or result verification.