Skip to content

[fix](test) Use the changelog properties in two tests merged before the changelog rename - #69373

Closed
morningman wants to merge 1 commit into
apache:masterfrom
morningman:changelog-fix-master-conflicts
Closed

morningman wants to merge 1 commit into
apache:masterfrom
morningman:changelog-fix-master-conflicts

Conversation

@morningman

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: #69311, #63639, #69268

Problem Summary:

In short. #69311 renamed row binlog to changelog: a changelog table is now created with "changelog.enable" = "true", gated by enable_feature_changelog, and DDL that still sets "binlog.format" or "binlog.need_historical_value" fails. Two tests that reached master a few hours before #69311 still create their tables the old way, so master fails them since #69311 was merged. This PR switches both to the new properties.

The problem. Each test was added by a PR that was green on its own; #69311's CI ran on a master without them, so neither side saw the conflict.

Test Added by On master now
FE UT RelationImpliedPredicateTest.testIvmOutputPredicatesSkipHiddenColumns (both parameters) #63639 DdlException: Property binlog.format is no longer supported, use "changelog.enable" = "true" to enable changelog, or remove it for CCR binlog when it creates its IVM base table
Regression mtmv_p0/ivm/test_ivm_datetime_sequence #69268 the same error on its first CREATE TABLE

Every PR's FE UT run includes RelationImpliedPredicateTest, so it fails for all PRs until this is merged.

How this PR fixes it. The same change #69311 made to the other IVM tests:

  • RelationImpliedPredicateTest: the base table uses 'changelog.enable' = 'true' instead of 'binlog.enable' = 'true', 'binlog.format' = 'ROW', and the test switches Config.enable_feature_changelog on (and restores it) instead of enable_feature_binlog, which no longer gates changelog tables.
  • test_ivm_datetime_sequence: both tables use "changelog.enable" = "true", "changelog.need_historical_value" = "true" instead of "binlog.enable" = "true", "binlog.format" = "ROW", "binlog.need_historical_value" = "true". Its queries and .out do not change.

Release note

None

Check List (For Author)

  • Test: Unit Test, Regression test
    • FE UT: RelationImpliedPredicateTest passes; on master both parameters of testIvmOutputPredicatesSkipHiddenColumns fail with the error above.
    • Regression: mtmv_p0/ivm/test_ivm_datetime_sequence passes against its existing .out on a local cluster.
  • Behavior changed: No
  • Does this need documentation: No

…he changelog rename

### What problem does this PR solve?

Issue Number: None

Related PR: apache#69311, apache#63639, apache#69268

Problem Summary:

**In short.** apache#69311 renamed row binlog to changelog: a changelog table is now created with `"changelog.enable" = "true"`, gated by `enable_feature_changelog`, and DDL that still sets `"binlog.format"` or `"binlog.need_historical_value"` fails. Two tests that reached master a few hours before apache#69311 still create their tables the old way, so master fails them since apache#69311 was merged. This PR switches both to the new properties.

**The problem.** Each test was added by a PR that was green on its own; apache#69311's CI ran on a master without them, so neither side saw the conflict.

| Test | Added by | On master now |
|---|---|---|
| FE UT `RelationImpliedPredicateTest.testIvmOutputPredicatesSkipHiddenColumns` (both parameters) | apache#63639 | `DdlException: Property binlog.format is no longer supported, use "changelog.enable" = "true" to enable changelog, or remove it for CCR binlog` when it creates its IVM base table |
| Regression `mtmv_p0/ivm/test_ivm_datetime_sequence` | apache#69268 | the same error on its first CREATE TABLE |

Every PR's FE UT run includes `RelationImpliedPredicateTest`, so it fails for all PRs until this is merged.

**How this PR fixes it.** The same change apache#69311 made to the other IVM tests:
- `RelationImpliedPredicateTest`: the base table uses `'changelog.enable' = 'true'` instead of `'binlog.enable' = 'true', 'binlog.format' = 'ROW'`, and the test switches `Config.enable_feature_changelog` on (and restores it) instead of `enable_feature_binlog`, which no longer gates changelog tables.
- `test_ivm_datetime_sequence`: both tables use `"changelog.enable" = "true", "changelog.need_historical_value" = "true"` instead of `"binlog.enable" = "true", "binlog.format" = "ROW", "binlog.need_historical_value" = "true"`. Its queries and `.out` do not change.

### Release note

None

### Check List (For Author)

- Test: Unit Test, Regression test
    - FE UT: `RelationImpliedPredicateTest` passes; on master both parameters of `testIvmOutputPredicatesSkipHiddenColumns` fail with the error above.
    - Regression: `mtmv_p0/ivm/test_ivm_datetime_sequence` passes against its existing `.out` on a local cluster.
- Behavior changed: No
- Does this need documentation: No

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman

Copy link
Copy Markdown
Contributor Author

close #

@morningman morningman closed this Oct 21, 2026
@morningman
morningman deleted the changelog-fix-master-conflicts branch October 22, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants