Repository navigation
[fix](test) Use the changelog properties in two tests merged before the changelog rename - #69373
Closed
morningman wants to merge 1 commit into
Closed
morningman wants to merge 1 commit into
morningman wants to merge 1 commit into
Conversation
…he changelog rename ### What problem does this PR solve? Issue Number: None Related PR: apache#69311, apache#63639, apache#69268 Problem Summary: **In short.** apache#69311 renamed row binlog to changelog: a changelog table is now created with `"changelog.enable" = "true"`, gated by `enable_feature_changelog`, and DDL that still sets `"binlog.format"` or `"binlog.need_historical_value"` fails. Two tests that reached master a few hours before apache#69311 still create their tables the old way, so master fails them since apache#69311 was merged. This PR switches both to the new properties. **The problem.** Each test was added by a PR that was green on its own; apache#69311's CI ran on a master without them, so neither side saw the conflict. | Test | Added by | On master now | |---|---|---| | FE UT `RelationImpliedPredicateTest.testIvmOutputPredicatesSkipHiddenColumns` (both parameters) | apache#63639 | `DdlException: Property binlog.format is no longer supported, use "changelog.enable" = "true" to enable changelog, or remove it for CCR binlog` when it creates its IVM base table | | Regression `mtmv_p0/ivm/test_ivm_datetime_sequence` | apache#69268 | the same error on its first CREATE TABLE | Every PR's FE UT run includes `RelationImpliedPredicateTest`, so it fails for all PRs until this is merged. **How this PR fixes it.** The same change apache#69311 made to the other IVM tests: - `RelationImpliedPredicateTest`: the base table uses `'changelog.enable' = 'true'` instead of `'binlog.enable' = 'true', 'binlog.format' = 'ROW'`, and the test switches `Config.enable_feature_changelog` on (and restores it) instead of `enable_feature_binlog`, which no longer gates changelog tables. - `test_ivm_datetime_sequence`: both tables use `"changelog.enable" = "true", "changelog.need_historical_value" = "true"` instead of `"binlog.enable" = "true", "binlog.format" = "ROW", "binlog.need_historical_value" = "true"`. Its queries and `.out` do not change. ### Release note None ### Check List (For Author) - Test: Unit Test, Regression test - FE UT: `RelationImpliedPredicateTest` passes; on master both parameters of `testIvmOutputPredicatesSkipHiddenColumns` fail with the error above. - Regression: `mtmv_p0/ivm/test_ivm_datetime_sequence` passes against its existing `.out` on a local cluster. - Behavior changed: No - Does this need documentation: No Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
morningman
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
October 21, 2026 07:14
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
close # |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #69311, #63639, #69268
Problem Summary:
In short. #69311 renamed row binlog to changelog: a changelog table is now created with
"changelog.enable" = "true", gated byenable_feature_changelog, and DDL that still sets"binlog.format"or"binlog.need_historical_value"fails. Two tests that reached master a few hours before #69311 still create their tables the old way, so master fails them since #69311 was merged. This PR switches both to the new properties.The problem. Each test was added by a PR that was green on its own; #69311's CI ran on a master without them, so neither side saw the conflict.
RelationImpliedPredicateTest.testIvmOutputPredicatesSkipHiddenColumns(both parameters)DdlException: Property binlog.format is no longer supported, use "changelog.enable" = "true" to enable changelog, or remove it for CCR binlogwhen it creates its IVM base tablemtmv_p0/ivm/test_ivm_datetime_sequenceEvery PR's FE UT run includes
RelationImpliedPredicateTest, so it fails for all PRs until this is merged.How this PR fixes it. The same change #69311 made to the other IVM tests:
RelationImpliedPredicateTest: the base table uses'changelog.enable' = 'true'instead of'binlog.enable' = 'true', 'binlog.format' = 'ROW', and the test switchesConfig.enable_feature_changelogon (and restores it) instead ofenable_feature_binlog, which no longer gates changelog tables.test_ivm_datetime_sequence: both tables use"changelog.enable" = "true", "changelog.need_historical_value" = "true"instead of"binlog.enable" = "true", "binlog.format" = "ROW", "binlog.need_historical_value" = "true". Its queries and.outdo not change.Release note
None
Check List (For Author)
RelationImpliedPredicateTestpasses; on master both parameters oftestIvmOutputPredicatesSkipHiddenColumnsfail with the error above.mtmv_p0/ivm/test_ivm_datetime_sequencepasses against its existing.outon a local cluster.