Repository navigation
branch-4.1: [fix](fe) Handle padded OIDC JDBC authentication payloads - #69714
Merged
yiguolei merged 1 commit intoOct 30, 2026
Merged
Conversation
### What problem does this PR solve? Issue Number: N/A Related PR: apache#63068 Problem Summary: MySQL Connector/J can append zero padding after a length-encoded OIDC JWT. branch-4.1 requires no remaining bytes and passes the complete encoded payload to JWT validation, rejecting valid credentials. Backport the master zero-padding check as a standalone fix, with tests for a long token and non-zero trailing data. ### Release note Fix OIDC JDBC login failures caused by trailing zero padding in MySQL Connector/J authentication payloads. ### Check List (For Author) - Test: Unit Test. 57 related tests pass; the new padding test fails before the fix. FE core Checkstyle reports zero violations. - Behavior changed: Yes. Accept zero padding after the OIDC token; preserve existing handling of non-zero trailing data. - Does this need documentation: No.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Member
Author
|
run feut |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE UT Coverage ReportIncrement line coverage |
Member
Author
|
run feut |
yiguolei
approved these changes
Oct 30, 2026
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #63068
MySQL Connector/J can send an
authentication_openid_connect_clientpayload containing the capability byte, a length-encoded JWT, and trailing zero padding. On branch-4.1,MysqlAuthPacketCredentialExtractorrequires that no bytes remain after the token. It therefore passes the entire encoded payload to the authentication plugin and a valid token fails withOIDC access token signature validation failed.Extract the padding fix already included in master by #63068 into a standalone branch-4.1 change. Accept trailing zero bytes while preserving the existing handling of non-zero trailing data. Add coverage for a token longer than 255 bytes with the six padding bytes produced by Connector/J, and for a non-zero byte following zero padding.
Release note
Fix OIDC JDBC login failures caused by trailing zero padding in MySQL Connector/J authentication payloads.
Check List (For Author)
build.sh --fewith UI disabled. For local packaging only, the BE/Cloud native dependency bootstrap was scoped to BE/Cloud because this host lacks Paimon native artifacts; the build script was restored and is not part of this PR.Check List (For Reviewer who merge this PR)