Repository navigation
[feature](changelog) Support VARIANT columns in changelog #69812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
csun5285
wants to merge
15
commits into
apache:master
Choose a base branch
from
csun5285:variant-serialize-type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f326b66
[feature](variant) Add a serialize type so that count 0 keeps every d…
csun5285 d16534a
[feature](changelog) Support VARIANT columns in changelog
csun5285 9a2db12
[fix](changelog) Skip the variant path stats check on changelog tablets
csun5285 58fae14
[test](changelog) Run existing changelog, stream, time travel and IVM…
csun5285 da3e987
[fix](variant) Check materialized inputs per segment and count BEFORE…
csun5285 eecfa49
[fix](variant) Keep the fuzzy variant subcolumn count above 0 in doc …
csun5285 d4c8fc7
[improvement](variant) Check the V2 count-0 layout in the reader and …
csun5285 ed97a67
[test](regression) Add the serialize type to the Paimon VARIANT DESC …
csun5285 6074bad
[chore](variant) Shorten the serialize type comments in the reader an…
csun5285 251d871
[fix](variant) Skip sub-path pruning for changelog() and print old VA…
csun5285 3a3c185
[improvement](variant) Make the serialize type an internal field
csun5285 95a4033
[fix](changelog) Reject doc mode sources and keep other scans pruned …
csun5285 008d696
[improvement](changelog) Keep the statement-wide pruning guard for Va…
csun5285 fe4b44a
[chore](variant) Merge master into variant-serialize-type
csun5285 24cb6a2
[test](regression) Pin the subcolumn count of the VARIANT column in t…
csun5285 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Accept historical layouts written by old cloud BEs
With the default
write_schema_kv=true, upgrade the FE before all BEs, create an ordinary count-zero VARIANT column, and load{"a":1}through an old BE. That BE ignores the new policy field and materializesa. However,CloudInternalCataloghas already persisted the V2 root schema;commit_rowsetseparates dynamic leaves into the dictionary whileput_schema_kvretains that existing root.get_rowsettherefore reconstructs a V2/count-zero schema for this materialized segment. A normal read after syncing it onto a fresh/upgraded BE reaches this check and fails (exception in Release, abort in Debug), making committed rows unreadable.This is distinct from existing compaction finding: it affects ordinary cloud reads without compaction, changelog, or a later schema change. Preserve/recognize the producer's physical layout, or gate V2 creation until writers support it, and cover an old-BE write followed by an upgraded-BE cloud read.