Skip to content

[fix](be) fix datasketches hll constant result - #69827

Open
nooneuse wants to merge 1 commit into
apache:masterfrom
nooneuse:fix-datasketches-hll-constant-result
Open

nooneuse wants to merge 1 commit into
apache:masterfrom
nooneuse:fix-datasketches-hll-constant-result

Conversation

@nooneuse

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

BE compilation fails after the constant-result API refactor in #69679. The datasketches_hll_downsample function added in #69257 still accesses column_ptr as a field, while its unit-test helper references the removed ColumnPtrWrapper type.

Use the read-only column() accessor when parsing lg_k and tgt_type, and migrate the unit-test helper to ConstantExprResult. This completes the missed API migration and restores BE and BE UT build compatibility.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants