Skip to content

branch-4.2: [improvement](auth) Scope mysql.user rows to the caller and mask password columns #67444 - #70120

Merged
yiguolei merged 1 commit into
apache:branch-4.2from
morrySnow:codex/branch-4.2-pick-67444
Nov 5, 2026
Merged

yiguolei merged 1 commit into
apache:branch-4.2from
morrySnow:codex/branch-4.2-pick-67444

Conversation

@morrySnow

Copy link
Copy Markdown
Contributor

picked from master #67444

…word columns

### What problem does this PR solve?

Related PR: apache#67444

Problem Summary: mysql.user 尚未按请求者限制账户行并统一屏蔽密码派生列

Backport adaptation: Keep the branch JUnit 4 test annotations and add the Assertions import used by the original new cases. TShowUserRequest field 1 remains optional and has the same user-identity meaning on master; field ID 1 is unused on branches 3.1/4.0/4.1/4.2. Old BE requests without identity return no rows on the new FE; upgrade BE first to preserve availability during rolling upgrades. Use the existing JUnit 4 fixture executeCommand helper to create the two wildcard-host accounts; this fixture does not inherit TestWithFeService.addUser. Test scenarios and assertions are unchanged.

### Release note

mysql.user 尚未按请求者限制账户行并统一屏蔽密码派生列

### Check List (For Author)

- Test: Unit Test — org.apache.doris.service.FrontendServiceImplTest; FE Checkstyle passed. BE ASAN build, formatting, targeted unit tests and clang-tidy passed; see local validation record. Static analysis used a task-local VFS overlay to remove an orphan NOLINTEND comment from the unchanged baseline types.h; production files and enabled checks were unchanged. Header hygiene gate unavailable: branch-4.2 does not contain build-support/check-build-hygiene.sh or its gates. Cluster regression tests were not run for this commit.
- Behavior changed: Yes, fixes the behavior described above.
- Does this need documentation: No

(cherry picked from commit 38339c5)
@morrySnow

Copy link
Copy Markdown
Contributor Author

run buildall

@morrySnow
morrySnow requested a review from yiguolei as a code owner November 3, 2026 12:06
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (11/11) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 64.78% (30357/46863)
Line Coverage 49.68% (321476/647131)
Region Coverage 45.44% (258912/569810)
Branch Coverage 47.12% (122446/259856)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.29% (34724/45514)
Line Coverage 61.16% (392465/641731)
Region Coverage 57.88% (330310/570665)
Branch Coverage 58.88% (152814/259544)

@yiguolei
yiguolei merged commit 4b9b7a5 into apache:branch-4.2 Nov 5, 2026
28 of 30 checks passed
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants