Skip to content

[chore](build) Update doris-skills submodule with four new skills - #70582

Merged
hello-stephen merged 1 commit into
apache:masterfrom
morningman:update-doris-skills-submodule
Nov 14, 2026
Merged

hello-stephen merged 1 commit into
apache:masterfrom
morningman:update-doris-skills-submodule

Conversation

@morningman

Copy link
Copy Markdown
Contributor

Background

doris-skills is a submodule that points at apache/doris-skills, the Apache Doris repository of agent skills: instructions and scripts that coding agents such as Claude Code and Codex load for Doris tasks. Nothing builds from it; it is checked out on request (git submodule update --init doris-skills) and by the CI jobs that clone every submodule. This repository pins c0aca2f (apache/doris-skills#2, June), which has three skills.

What problem does this PR solve?

Issue Number: None
Related PR: #64240 (the previous update of this pointer), #70422 (moves the same pointer to 0b36dcb and adds the AGENTS.md guidance; conflicts with this PR on that line), apache/doris-skills#17 (the commit this PR pins)
PR Type: Build/CI/Chore

Problem Summary:

Since c0aca2f, doris-skills has merged 13 PRs that add four skills, for debugging, local PR review, development, and PR descriptions, and a checkout of this repository still gets none of them. This PR moves the pointer to c353d71, the tip of doris-skills main, and changes nothing else. Builds, tests, and Doris users see no change.

Skills in doris-skills/skills/
master (c0aca2f) doris-architecture-advisor, doris-best-practices, doris-profile-reader
this PR (c353d71) develop-with-evidence, doris-architecture-advisor, doris-best-practices, doris-debug, doris-pr-description, doris-profile-reader, doris-repo-review

Details

  • Affected: Only the doris-skills pointer. The CI jobs that clone every submodule (submodules: recursive in be-ut-mac.yml, build-extension.yml, build-thirdparty.yml, build-ui.yml, and checkstyle.yaml, and git submodule update --init --recursive --depth 1 in the performance pipeline's compile.sh) clone doris-skills at c353d71 without reading it; build.sh and run-be-ut.sh update only the contrib/ submodules they name.
  • Developer and release impact: Developers who check out the submodule get the seven skills at c353d71, about 2.3 MB; existing checkouts keep their commit until the next git submodule update. Release builds don't change, since no script in this repository reads doris-skills.
  • License and third-party: None. doris-skills is an Apache-2.0 repository of the ASF, and no file from it is added to this tree.
  • Rollback: Revert this PR; local submodule checkouts made meanwhile do no harm.

Testing

  • git ls-remote https://github.com/apache/doris-skills refs/heads/main returns c353d71bc50d6c0baf1831dec33cbfa0abc64ef2, the commit this PR pins: the squash merge of feat(doris-pr-description): show the problem with a concrete example doris-skills#17, not a PR-only commit. c0aca2f is its ancestor.
  • A fresh clone of the URL in .gitmodules, checked out at c353d71 as git submodule update --init doris-skills does, holds the seven skills in the table above.
  • python3 skills/doris-pr-description/scripts/check_pr.py --self-test at c353d71 reports Self-test: 11 examples in 10 files, 0 problems.

Notes for Reviewers

Release note

None

Check List (For Author)

  • Behavior changed: No
  • Does this need documentation: No
  • Pre-submission status: Ready

AI Disclosure

### Background

`doris-skills` is a submodule that points at apache/doris-skills, the Apache Doris repository of agent skills: instructions and scripts that coding agents such as Claude Code and Codex load for Doris tasks. Nothing builds from it; it is checked out on request (`git submodule update --init doris-skills`) and by the CI jobs that clone every submodule. This repository pins `c0aca2f` (apache/doris-skills#2, June), which has three skills.

### What problem does this PR solve?

Issue Number: None
Related PR: apache#64240 (the previous update of this pointer), apache#70422 (moves the same pointer to `0b36dcb` and adds the `AGENTS.md` guidance; conflicts with this PR on that line), apache/doris-skills#17 (the commit this PR pins)
PR Type: Build/CI/Chore

Problem Summary:

Since `c0aca2f`, doris-skills has merged 13 PRs that add four skills, for debugging, local PR review, development, and PR descriptions, and a checkout of this repository still gets none of them. This PR moves the pointer to `c353d71`, the tip of doris-skills `main`, and changes nothing else. Builds, tests, and Doris users see no change.

| | Skills in `doris-skills/skills/` |
|---|---|
| master (`c0aca2f`) | `doris-architecture-advisor`, `doris-best-practices`, `doris-profile-reader` |
| this PR (`c353d71`) | `develop-with-evidence`, `doris-architecture-advisor`, `doris-best-practices`, `doris-debug`, `doris-pr-description`, `doris-profile-reader`, `doris-repo-review` |

### Details

- **Affected:** Only the `doris-skills` pointer. The CI jobs that clone every submodule (`submodules: recursive` in `be-ut-mac.yml`, `build-extension.yml`, `build-thirdparty.yml`, `build-ui.yml`, and `checkstyle.yaml`, and `git submodule update --init --recursive --depth 1` in the performance pipeline's `compile.sh`) clone doris-skills at `c353d71` without reading it; `build.sh` and `run-be-ut.sh` update only the `contrib/` submodules they name.
- **Developer and release impact:** Developers who check out the submodule get the seven skills at `c353d71`, about 2.3 MB; existing checkouts keep their commit until the next `git submodule update`. Release builds don't change, since no script in this repository reads `doris-skills`.
- **License and third-party:** None. doris-skills is an Apache-2.0 repository of the ASF, and no file from it is added to this tree.
- **Rollback:** Revert this PR; local submodule checkouts made meanwhile do no harm.

### Testing

- `git ls-remote https://github.com/apache/doris-skills refs/heads/main` returns `c353d71bc50d6c0baf1831dec33cbfa0abc64ef2`, the commit this PR pins: the squash merge of apache/doris-skills#17, not a PR-only commit. `c0aca2f` is its ancestor.
- A fresh clone of the URL in `.gitmodules`, checked out at `c353d71` as `git submodule update --init doris-skills` does, holds the seven skills in the table above.
- `python3 skills/doris-pr-description/scripts/check_pr.py --self-test` at `c353d71` reports `Self-test: 11 examples in 10 files, 0 problems`.

### Notes for Reviewers

- The pointer moves over 13 commits of apache/doris-skills (#3 to apache#17), +10,047 −45 in 114 files, each reviewed and merged there; the three skills pinned today don't change. In this repository's diff, only the pin itself needs checking.
- apache#70422 changes the same line, to `0b36dcb` (apache/doris-skills#16). Whichever of the two merges second keeps `c353d71`.

### Release note

None

### Check List (For Author)

- Behavior changed: No
- Does this need documentation: No
- Pre-submission status: Ready

### AI Disclosure

- Tool: Claude Code (Claude Opus 5.5)
- Generated: the submodule update and this description
- Human review: not stated
- Prompts: After apache/doris-skills#17 merged, the author asked for a separate PR that only updates the doris-skills submodule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@morningman

Copy link
Copy Markdown
Contributor Author

skip buildall

@hello-stephen
hello-stephen merged commit 42b148b into apache:master Nov 14, 2026
34 checks passed
hello-stephen pushed a commit that referenced this pull request Nov 15, 2026
### Background

The macOS BE build, large-file check, and license check each run on
pushes to `master`. The large-file and license workflows also check pull
requests, and the macOS workflow has a daily schedule for warming its
build cache.

### What problem does this PR solve?

Issue Number: None
Related PR: #70582 (example of unnecessary post-merge checks)
PR Type: Build/CI/Chore

Problem Summary:

Every merge into `master` starts these three checks, even when the
change only updates a skills submodule, as in #70582. These post-merge
runs consume runners and can mark commits as failing because of
unrelated build problems. Remove the `push` triggers and their
event-specific code while preserving the existing PR checks and daily
macOS build.

### Details

- **Affected:** The macOS BE build on `macos-15` and the large-file and
license checks on `ubuntu-latest` in GitHub Actions.
- **Developer and release impact:** Merging into `master` no longer
starts these checks. The macOS workflow keeps its daily cache warm-up;
large-file warnings and incremental license checks still run for PRs.
Local builds and release artifacts do not change.
- **License and third-party:** None. Dependencies, license rules, and
third-party artifacts do not change.
- **Rollback:** Revert this commit to restore checks on pushes to
`master`; no cache, runner, or secret changes are required.

### Testing

- Parsed all 20 workflow YAML files locally with PyYAML and verified
that none declares a `push` event. Compared against the parent revision
to confirm that all other event definitions are preserved, including the
macOS schedule and both PR triggers.
- Checked that the large-file size and PR warning scripts and all
license-check steps are unchanged. Ran `bash -n` on all seven embedded
shell steps in the modified workflows.
- Ran actionlint v1.7.12 on the three modified workflows. Both the
parent revision and this change report the same existing
`actions/checkout@v3` deprecation; validation passes when excluding that
specific diagnostic.
- No BE or FE build was run because the change only affects workflow
triggers and removes the unused push path.

### Release note

None

### Check List (For Author)

- Behavior changed: No
- Does this need documentation: No
- Pre-submission status: Ready

### AI Disclosure

- Tool: Codex (GPT-6)
- Generated: Workflow edits and this description
- Human review: not stated

Co-authored-by: morningman <moringman@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants