Skip to content

[fix](build) Refresh the Arrow ADBC source archive checksum - #70610

Merged
morningman merged 2 commits into
apache:masterfrom
suxiaogang223:codex/fix-adbc-source-checksum
Nov 17, 2026
Merged

morningman merged 2 commits into
apache:masterfrom
suxiaogang223:codex/fix-adbc-source-checksum

Conversation

@suxiaogang223

@suxiaogang223 suxiaogang223 commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Background

Third-party builds verify downloaded source archives against checksums in thirdparty/vars.sh. The current master checksum for the Arrow ADBC 24 GitHub archive no longer matches the download.

What problem does this PR solve?

Issue Number: None
Related PR: None
PR Type: Bugfix

Problem Summary:

Update the Arrow ADBC source checksum so fresh third-party downloads can complete. This fixes the download failure blocking compile and BEUT CI.

Details

  • Frequency: Fresh downloads fail; the original cached archive still passes.
  • Root cause: GitHub's archive substitution now emits an 11-character Git hash instead of 10 characters in four Python _static_version.py files, changing the archive checksum. All other archive entries are unchanged.
  • Why existing tests missed it: Download tests use local fixtures and do not detect upstream archive changes.
  • Fix: Update only ARROW_ADBC_MD5SUM; retain the version, URL and checksum verification.
  • Other paths and branches: All platforms share this master download configuration.
  • Behavior change: Fresh downloads accept the current upstream archive.

Testing

Earlier investigation downloaded the archive and reproduced CI's MD5 (3d6aaf071d384fe8d3c12a9b5f62aa4e). Compared all 2,234 archive entries with the original cached archive; only the four Git hash substitutions differ. No local build or test run for this one-line fix, as requested.

Release note

Fix Arrow ADBC source checksum verification during third-party builds.

Check List (For Author)

  • Behavior changed: Yes (see Details).
  • Does this need documentation: No.
  • Pre-submission status: Partially verified: archive comparison completed; build/test validation is left to CI.

AI Disclosure

  • Tool: Codex.
  • Generated: checksum update and PR description.
  • Human review: Pending author and maintainer review.

### Background

Third-party builds verify downloaded source archives against checksums in `thirdparty/vars.sh`. The current master checksum for the Arrow ADBC 24 GitHub archive no longer matches the download.

### What problem does this PR solve?

Issue Number: None
Related PR: apache#70598 (exposes this existing build failure)
PR Type: Bugfix

Problem Summary:

Update the Arrow ADBC source checksum so fresh third-party downloads can complete. This fixes the download failure blocking compile and BEUT CI.

### Details

- **Frequency:** Fresh downloads fail; the original cached archive still passes.
- **Root cause:** GitHub's archive substitution now emits an 11-character Git hash instead of 10 characters in four Python `_static_version.py` files, changing the archive checksum. All other archive entries are unchanged.
- **Why existing tests missed it:** Download tests use local fixtures and do not detect upstream archive changes.
- **Fix:** Update only `ARROW_ADBC_MD5SUM`; retain the version, URL and checksum verification.
- **Other paths and branches:** All platforms share this master download configuration.
- **Behavior change:** Fresh downloads accept the current upstream archive.

### Testing

Earlier investigation downloaded the archive and reproduced CI's MD5 (`3d6aaf071d384fe8d3c12a9b5f62aa4e`). Compared all 2,234 archive entries with the original cached archive; only the four Git hash substitutions differ. No local build or test run for this one-line fix, as requested.

### Release note

Fix Arrow ADBC source checksum verification during third-party builds.

### Check List (For Author)

- Behavior changed: Yes (see Details).
- Does this need documentation: No.
- Pre-submission status: Partially verified: archive comparison completed; build/test validation is left to CI.

### AI Disclosure

- Tool: Codex.
- Generated: checksum update and PR description.
- Human review: Pending author and maintainer review.
@suxiaogang223

Copy link
Copy Markdown
Member Author

run buildall

@suxiaogang223

Copy link
Copy Markdown
Member Author

/review

@github-actions

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: Review setup stopped before context preparation ran; inspect the first failed or cancelled setup step.
Workflow run: https://github.com/apache/doris/actions/runs/43840234977

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

hello-stephen
hello-stephen previously approved these changes Nov 16, 2026
yiguolei
yiguolei previously approved these changes Nov 16, 2026
@hello-stephen
hello-stephen dismissed stale reviews from yiguolei and themself via 33eb34e November 16, 2026 12:10
@suxiaogang223

Copy link
Copy Markdown
Member Author

Local review completed with Codex using Doris's code-review skill. No findings. The Arrow ADBC archive was checked against the upstream tag, and the local downloader passed both a fresh download and stale-cache replacement. The third-party script tests and Linux, macOS, and macOS ARM64 builds passed in CI for this head.

schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70610
commit: 33eb34e633899967931f7f1704f0bb2afe590172
base: 70fc3282b393c86f81957a127886d5c375c675ee
reviewed_at: 2026-11-17T02:18:42Z
reviewer: suxiaogang223
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true

@morningman
morningman merged commit 687a22d into apache:master Nov 17, 2026
38 checks passed
@suxiaogang223
suxiaogang223 deleted the codex/fix-adbc-source-checksum branch November 17, 2026 02:39
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants