Repository navigation
[fix](tablet) Count stale rowsets correctly in metadata size checks - #70683
Open
foxtail463 wants to merge 1 commit into
Open
foxtail463 wants to merge 1 commit into
foxtail463 wants to merge 1 commit into
Conversation
foxtail463
requested review from
gavinchou,
liaoxin01 and
yiguolei
as code owners
November 17, 2026 09:54
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
stale_version_count() returned the active rowset count, causing metadata size checks to reject valid loads prematurely or underestimate retained metadata when active and stale counts differed.
Solution:
Return the size of _stale_rs_metas from TabletMeta::stale_version_count(). Existing load and push checks then estimate metadata size using the sum of active and stale rowsets.