Repository navigation
Conversation
Problem Summary: When a BE receives its cluster token or a new authentication token, heartbeat INFO logs include the credential values. A cluster-token mismatch also includes both tokens in the error response, which can propagate to FE logs. Keep the heartbeat event messages and invalid-token error while removing credential values. Add a unit test covering initialization, repeated heartbeats, successive authentication-token updates, and token mismatch, including checks that logs and error responses do not contain the credentials. (cherry picked from commit c3c7af5)
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from #69532
Problem Summary: When a BE receives its cluster token or a new authentication token, heartbeat INFO logs include the credential values. A cluster-token mismatch also includes both tokens in the error response, which can propagate to FE logs. Keep the heartbeat event messages and invalid-token error while removing credential values. Add a unit test covering initialization, repeated heartbeats, successive authentication-token updates, and token mismatch, including checks that logs and error responses do not contain the credentials.
(cherry picked from commit c3c7af5)
Background
What problem does this PR solve?
Issue Number:
Related PR:
PR Type:
Problem Summary:
Details
Testing
Notes for Reviewers
Release note
Check List (For Author)
AI Disclosure