Skip to content

[fix](be) Remove heartbeat tokens from logs and errors (#69532) - #70692

Open
deardeng wants to merge 1 commit into
apache:branch-4.2from
deardeng:codex/pick-69532-to-branch-4.2
Open

deardeng wants to merge 1 commit into
apache:branch-4.2from
deardeng:codex/pick-69532-to-branch-4.2

Conversation

@deardeng

Copy link
Copy Markdown
Contributor

pick from #69532
Problem Summary: When a BE receives its cluster token or a new authentication token, heartbeat INFO logs include the credential values. A cluster-token mismatch also includes both tokens in the error response, which can propagate to FE logs. Keep the heartbeat event messages and invalid-token error while removing credential values. Add a unit test covering initialization, repeated heartbeats, successive authentication-token updates, and token mismatch, including checks that logs and error responses do not contain the credentials.

(cherry picked from commit c3c7af5)

Background

What problem does this PR solve?

Issue Number:
Related PR:
PR Type:

Problem Summary:

Details

Testing

Notes for Reviewers

Release note

Check List (For Author)

  • Behavior changed:
  • Does this need documentation:
  • Pre-submission status:

AI Disclosure

  • Tool:
  • Generated:
  • Human review:

Problem Summary: When a BE receives its cluster token or a new
authentication token, heartbeat INFO logs include the credential values.
A cluster-token mismatch also includes both tokens in the error
response, which can propagate to FE logs. Keep the heartbeat event
messages and invalid-token error while removing credential values. Add a
unit test covering initialization, repeated heartbeats, successive
authentication-token updates, and token mismatch, including checks that
logs and error responses do not contain the credentials.

(cherry picked from commit c3c7af5)
@deardeng
deardeng requested a review from yiguolei as a code owner November 17, 2026 11:12
@deardeng

Copy link
Copy Markdown
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant