Repository navigation
[fix](regression) Make test_minio_storage_vault honor enableExternalMinioTest - #70698
Open
costajohnt wants to merge 1 commit into
Open
costajohnt wants to merge 1 commit into
costajohnt wants to merge 1 commit into
Conversation
…inioTest Both skip guards in test_minio_storage_vault only logged and fell through, and the MinIO check used && so it threw an NPE when enableExternalMinioTest was unset and was false otherwise. Return from both guards, skip unless the flag is true, and set the flag in the vault_p0 pipeline config, which starts the MinIO container this case uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #50703
Problem Summary:
test_minio_storage_vaulthas two skip guards that only log and then fall through, so the case never skips. The MinIO guard also usesenabled == null && enabled.equalsIgnoreCase("false"), which throws a NullPointerException whenenableExternalMinioTestis unset and is false in every other case. This PR returns from both guards and skips unlessenableExternalMinioTestis true. It also setsenableExternalMinioTest = truein the vault_p0 pipeline config, which already starts the MinIO container and holds theextMinio*settings for this case, so the case keeps running there.Details
enableExternalMinioTest = false, it runs anyway and fails if no MinIO is reachable.returnin both guards, and&&where the check needs||with a test for "true".enableStoragevault()guard as before.Testing
I checked the guard against Doris's config loading path (ConfigSlurper, then
toProperties, thenotherConfigs) on Groovy 3.0.25 and 4.0.24. With the old guard, an unset flag throws an NPE andfalseruns the case. With the new guard, both skip, and the vault_p0 override (true) runs it. I have not run the suite against a cluster.Release note
None
Check List (For Author)
AI Disclosure
Found with groovyfmt, a Groovy formatter and linter.