Repository navigation
fix: implement makeAggregateCombiner for momentSketch - #20413
Conversation
Rollup ingestion that persists more than one intermediate index merges them through RowCombiningTimeAndDimsIterator, which needs an AggregateCombiner. MomentSketchAggregatorFactory did not provide one, so the merge failed with UOE. Fixes apache#13220
FrankChen021
left a comment
There was a problem hiding this comment.
🟢 Approval recommended
Reviewed 3 of 3 changed files.
The new combiner follows the AggregateCombiner contract by accumulating into a fresh MomentSketchWrapper, preserving source segment objects while handling null selectors. The added factory-level test covers multi-sketch folding and source immutability, and the ingestion test exercises rollup across persisted indexes. I found no actionable correctness, compatibility, concurrency, security, or data-loss issues in the current diff.
This is an automated review by Codex GPT-5.6-Luna(max)
|
Thanks for the review. The one red check (QTest 1/4) failed during dependency resolution: repo.maven.apache.org returned HTTP 429 Too Many Requests before any test ran (job 107442169669). This PR only touches the momentsketch extension. Could someone with access re-run that job? |
Fixes #13220.
Description
MomentSketchAggregatorFactoryhad nomakeAggregateCombiner(), so rollup ingestion that persists more than one intermediate index failed inIndexMergerV9with the UOE from the issue. The existing test never merged: the data rolls up to 9 rows andmaxRowCountis 10.The combiner follows
TDigestSketchAggregatorFactory:resetstarts a new sketch with the factory'skandcompress, andfoldmerges into it, never into the selector's object.Tests: an ingestion test with
maxRowCount3, and a unit test for the combiner. Both fail with the UOE without the fix. The module tests (29), checkstyle and forbiddenapis pass.Release note
Fixed rollup ingestion with
momentSketchmetrics failing during index merge.