Repository navigation
fix: Allow segment pruners to indicate what segment details they need to effectively prune + fixup MSQ table slicer to honor such requests - #20892
Open
capistrant wants to merge 2 commits into
Conversation
FrankChen021
left a comment
Member
There was a problem hiding this comment.
🟢 Approval recommended
No actionable issues found. The required segment details are correctly propagated through the MSQ slicer and action clients, with coverage for cluster-group pruning and detail requests.
Reviewed 9 of 9 changed files.
Validation: git diff --check passed. No tests or builds were run.
This is an automated review by Codex GPT-5.6-Luna(max)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FilterSegmentPrunercan prune segments based on cluster groups for segments that are built using them since #20149. This should allow msq-task engine queries to prune segments when cluster groups are being filtered on. However, that is not the case because #20006 cut back on the segment details that the RetrieveUsedSegmentsAction grabs.In the effort to actually support full pruning capabilities for
FilterSegmentPruner(and create a path forward for future pruners), this PR proposes theSegmentPrunerinterface gains a new methodgetRequiredSegmentDetailswhich returns segment details it needs to make pruning decisions. The MSQ module takes advantage of this new method in the table input slicer by submitting theRetrieveUsedSegmentsActionrequest with the details needed by the pruner, if any exist. This allows msq-task queries to prune on cluster groups when there are there.Release note
Close a functionality gap in segment pruning by msq-task queries by providing them the information about the input segments that they need to prune on cluster groups if the query is filtering on columns that are cluster group column in the underlying data. Enhancing the impact of #20149
Key changed/added classes in this PR
SegmentPrunerFilterSegmentPrunerIndexerTableInputSpecSlicerThis PR has: