Repository navigation
Fail a retried upsert instead of inserting a concurrently inserted key - #4392
Open
Anurag-S1ngh wants to merge 1 commit into
Open
Anurag-S1ngh wants to merge 1 commit into
Anurag-S1ngh wants to merge 1 commit into
Conversation
A commit retry replays the append that was planned before the concurrent commit, and the fast append producer skips concurrency validation, so a key another writer inserted after the upsert read ends up inserted twice. Record the filter for the rows an upsert inserts on the append producer and validate the files added since the starting snapshot against it when the commit is rebuilt for a retry. The upsert now fails with a CommitFailedException instead of leaving a duplicate key.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A commit retry replays the append planned before the concurrent commit. The fast append producer skips concurrency validation, so a key another writer inserted after the upsert read was inserted a second time.
Changes
CommitFailedExceptioninstead of inserting a duplicate key.Testing
make testpasses (4697 passed, 5 skipped).Closes #4194