Skip to content

chore(deps): update dependencies to address security advisories - #3558

Merged
kevinjqliu merged 3 commits into
apache:0.11.xfrom
dannycjones:bump-0.11.x-audit-advisories
Oct 27, 2026
Merged

kevinjqliu merged 3 commits into
apache:0.11.xfrom
dannycjones:bump-0.11.x-audit-advisories

Conversation

@dannycjones

@dannycjones dannycjones commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Supports #3034.

What changes are included in this PR?

Backports the security advisory fixes from main to 0.11.x, one commit each:

Not included: the event-listener, chacha20 and spin bumps from #3425, and the RUSTSEC-2026-0381 ignore from #3496. cargo audit passes without them.

Are these changes tested?

  • cargo audit: passes. It reports 14 vulnerabilities on 0.11.x without this PR.
  • cargo about generate -c about.toml --locked --fail --manifest-path Cargo.toml in bindings/python: passes with no warnings, and the output includes the Meta notices for zstd-sys.

AI Disclosure

LLM used to validate the advisories, restructure the backport, align versions with main, and run the checks above. Reviewers should check that the #3542 commit still matches #3542 when it merges.

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question about about.toml changes

For future reference, I think it would be good to include in the PR description references of which PRs we're backporting, just to keep track. And also which changes are net new to the branch.

Comment thread .cargo/audit.toml
Comment on lines +67 to +83
# `zstd` < 0.14.3 / `zstd-safe` < 8.2.0 memory-safety bugs.
#
# Fixed only in zstd 0.14, but parquet 58 and apache-avro 0.21 require
# zstd 0.13. Remove once on parquet >= 60
# (https://github.com/apache/iceberg-rust/pull/3257), an apache-avro release
# after 0.21, and workspace `zstd` >= 0.14.3.
#
# None of the affected code is reachable here. To re-check, run
# `cargo tree --workspace --all-features --target all -e features -i zstd-safe`
# and confirm only `std` is enabled.
#
# Affects only zstd's `with_context` constructors, which nothing calls.
"RUSTSEC-2026-0391",
# Requires the `seekable` feature, which is off.
"RUSTSEC-2026-0398",
# Requires the `legacy` feature, which is off.
"RUSTSEC-2026-0403",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checksum = "3823dda7cf046602f4b4e77ec8e227863dc4736037cc85bb33d9f19febe16bb7"
path = "LICENSE.txt"

# zstd-sys vendors zstd's C code (BSD-3-Clause, Meta) next to the Rust

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

I see the corresponding PR is not merged
https://github.com/apache/iceberg-rust/pull/3542/changes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop, this PR is what invalidates these clauses which is why I included them (and should have been included in the original PR upstream).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now maps to #3542

@kevinjqliu

Copy link
Copy Markdown
Contributor

We remove clarifications no longer required (same for main, I'll open that later) and adds any remaining security audit config changes we still need.

I think we should keep changes in the 0.11.x branch as minimal as possible and only to backport changes. Otherwise its hard to reason about in the future.

@dannycjones

Copy link
Copy Markdown
Contributor Author

1 question about about.toml changes

For future reference, I think it would be good to include in the PR description references of which PRs we're backporting, just to keep track. And also which changes are net new to the branch.

Absolutely agree, sorry I missed it in this one! I've added them now.

@kevinjqliu

Copy link
Copy Markdown
Contributor

Absolutely agree, sorry I missed it in this one! I've added them now.

no worries, just a pointer so its easier for us to reason about in the future 😄

dannycjones and others added 3 commits October 27, 2026 12:26
* chore(deps): bump zstd-sys to 2.1.2 to fix RUSTSEC-2026-0410

Co-authored-by: Danny C Jones <djonesoa@amazon.com>

* ci: ignore unreachable zstd RUSTSEC advisories pending zstd 0.14 upstream

Co-authored-by: Danny C Jones <djonesoa@amazon.com>

* Address comments from Copilot

Co-authored-by: Danny C Jones <djonesoa@amazon.com>

* ci: clarify zstd advisory ignore rationale and removal condition

Map each ignored advisory to why it is unreachable, add a command to
re-check enabled zstd features, and include the workspace zstd bump in
the removal condition.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit e4f928a)
[0.11.x: audit.toml comment names parquet 58 and apache-avro 0.21]
zstd-sys 2.1.2 removed LICENSE.Mit and changed LICENSE.BSD-3-Clause, so the
old clarification stopped matching and cargo-about dropped the Meta notices
for the bindings and the vendored zstd C code. Pin the 2.1.2 files instead
of removing the clarification.

Backport of apache#3542 at 54a20b2 (not yet merged).

Co-authored-by: Danny C Jones <djonesoa@amazon.com>
Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… advisories

Lockfile bumps from main, at main's versions:
- quinn-proto 0.11.19 (apache#3425)
- rustls 0.23.46, with aws-lc-rs 1.18.1 and aws-lc-sys 0.45.0 (apache#3455)
- rustls-webpki 0.103.16, webpki-roots and webpki-root-certs 1.0.10 (apache#3496)
- ctutils 0.4.5 (apache#3519)

Co-authored-by: Danny C Jones <djonesoa@amazon.com>
Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kevinjqliu
kevinjqliu force-pushed the bump-0.11.x-audit-advisories branch from 06291f0 to 11a3d56 Compare October 27, 2026 19:26

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I updated the pr and description to reference the PRs we are backporting

checksum = "3823dda7cf046602f4b4e77ec8e227863dc4736037cc85bb33d9f19febe16bb7"
path = "LICENSE.txt"

# zstd-sys vendors zstd's C code (BSD-3-Clause, Meta) next to the Rust

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now maps to #3542

@kevinjqliu

Copy link
Copy Markdown
Contributor

waiting for ci to run to completion before pressing "squash and merge"

@dannycjones
dannycjones force-pushed the bump-0.11.x-audit-advisories branch from f16959d to 11a3d56 Compare October 27, 2026 20:54
@kevinjqliu
kevinjqliu merged commit 284b4fc into apache:0.11.x Oct 27, 2026
39 checks passed
@dannycjones
dannycjones deleted the bump-0.11.x-audit-advisories branch October 27, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants