Repository navigation
Conversation
An engine that splits a data file into several read tasks must cut on the row-group boundaries the writer recorded as `split_offsets` (spec field 132), or a split can land inside a row group and one of the two tasks opens the file for nothing. `FileScanTask` had no way to hand them on, so an engine planning with iceberg-rust had to split arithmetically. Measured with Spark 3.5.8 planning through a JNI binding of this crate: on a table of sixty 30 MB single-row-group Parquet files on S3, Spark produced 120 input partitions instead of 60 and the scan stage took twice as long as with Iceberg Java planning, although the plan itself was two orders of magnitude faster. With the offsets carried the two planners yield identical splits. - `FileScanTask::split_offsets: Option<Vec<i64>>`, builder default, accessor, serde in both directions; `None` when the writer recorded none. - Populated from the manifest entry's `DataFile` in `ManifestEntryContext:: into_file_scan_task`. - `TableTestFixture::setup_manifest_files_with_split_offsets` and a scan test covering recorded, empty and absent offsets; the serde round-trip test carries the field.
CTTY
marked this pull request as ready for review
November 16, 2026 22:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
An engine that splits a data file into several read tasks must cut on the row-group boundaries the writer recorded as
split_offsets(spec field 132), or a split can land inside a row group and one of the two tasks opens the file for nothing.FileScanTaskhad no way to hand them on, so an engine planning with iceberg-rust had to split arithmetically.FileScanTask::split_offsets: Option<Vec<i64>>, builder default, accessor, serde in both directions;Nonewhen the writer recorded none.DataFileinManifestEntryContext:: into_file_scan_task.TableTestFixture::setup_manifest_files_with_split_offsetsand a scan test covering recorded, empty and absent offsets; the serde round-trip test carries the field.Are these changes tested?
AI Disclosure
Used claude